Bug 27696 - Add a dedicated self checkout (SCO) issue slip
Summary: Add a dedicated self checkout (SCO) issue slip
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-12 17:34 UTC by Lucas Gass
Modified: 2023-03-16 14:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27696: add SCOSlipChoice system pref (5.12 KB, patch)
2021-02-12 17:45 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 27696: add SCOSlipChoice system pref (5.17 KB, patch)
2021-02-25 17:05 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2021-02-12 17:34:57 UTC
Some libraries like to print the issue quick slip from the SCO page, others like to print the regular issue slip here. 

We should allow for librarians to choose which one they'd like their patrons to get.
Comment 1 Lucas Gass 2021-02-12 17:45:20 UTC
Created attachment 116840 [details] [review]
Bug 27696: add SCOSlipChoice system pref

To test:
1. Apply patch, updatedatabase.
2. Look for the new system preference SCOSlipChoice.
3. Make sure your ISSUESLIP and ISSUEQSLIP have different info in them so you can differentiate between the two.
3. Switch SCOSlipChoice to ISSUESLIP, make sure the SCO now prints the issue slip.
4. Switch SCOSlipChoice to ISSUEQSLIP, make sure the SCO now prints the issue quick slip.
Comment 2 Owen Leonard 2021-02-25 17:05:56 UTC
Created attachment 117349 [details] [review]
Bug 27696: add SCOSlipChoice system pref

To test:
1. Apply patch, updatedatabase.
2. Look for the new system preference SCOSlipChoice.
3. Make sure your ISSUESLIP and ISSUEQSLIP have different info in them so you can differentiate between the two.
3. Switch SCOSlipChoice to ISSUESLIP, make sure the SCO now prints the issue slip.
4. Switch SCOSlipChoice to ISSUEQSLIP, make sure the SCO now prints the issue quick slip.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Kyle M Hall 2021-04-09 17:13:30 UTC
I hate to complicate things, but would it be simpler to give SCO it's own slip? I've got no problem with this solution as it stands.
Comment 4 Lucas Gass 2021-04-15 13:57:27 UTC
(In reply to Kyle M Hall from comment #3)
> I hate to complicate things, but would it be simpler to give SCO it's own
> slip? I've got no problem with this solution as it stands.

It is more complicated but I do like this idea. +1
Comment 5 Marcel de Rooy 2021-07-09 08:10:18 UTC
INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
[...]
+('SCOSlipChoice' , '0', 'issueqlsip', 'issueqslip|issueslip', 'Allow choice for SCO receipt print',  'Choice' ),
The fields do not match!
Value 0 is not correct. The options are not correct too etc.
Please make sure that the former default == qslip is inserted.

Note that it is confusing too that the sco script tests for qslip and our values are issueslip and issueqslip.
sco script contains:
if (my $letter = IssueSlip ($session->param('branch') || $branch, $borrowernumber, $print eq "qslip")) {
We even have wrong calls in a test like:
t/db_dependent/Members/IssueSlip.t:        $slip = IssueSlip( $branchcode, $borrowernumber, 'quickslip' );
I would recommend to correct that too.
Comment 6 Marcel de Rooy 2021-07-09 08:11:55 UTC
(In reply to Lucas Gass from comment #4)
> (In reply to Kyle M Hall from comment #3)
> > I hate to complicate things, but would it be simpler to give SCO it's own
> > slip? I've got no problem with this solution as it stands.
> 
> It is more complicated but I do like this idea. +1

+1
Comment 7 Katrin Fischer 2023-01-23 22:04:10 UTC
Still valid. 

Lucas, this is assigned to you - is this correct?