Bug 27751

Summary:	Phase out jquery.cookie.js: Batch item modifications
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	fridolin.somers, testopia
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	21.05.00
Circulation function:
Bug Depends on:	23944, 27752
Bug Blocks:	27750
Attachments:	Bug 27751: Phase out jquery.cookie.js: Batch item modifications Bug 27751: Phase out jquery.cookie.js: Batch item modifications Bug 27751: Phase out jquery.cookie.js: Batch item modifications

Description Owen Leonard 2021-02-22 15:19:31 UTC

The batch item modification and deletion interfaces use a cookie to remember which columns in the table are shown or hidden. These templates should be modified to use the newer cookie plugin, js-cookie.

Comment 1 Owen Leonard 2021-02-22 16:52:32 UTC

Created attachment 117171 [details] [review]
Bug 27751: Phase out jquery.cookie.js: Batch item modifications

To test, apply the patch and go to Tools -> Batch item modification.

- Submit a batch of barcodes for modification.
- Uncheck some checkboxes to hide columns in the table showing your
  submitted items.
- Return to the batch item modification page and submit your batch
  again.
- The columns you selected should still be hidden.
- Submit a batch of items for deletion.
- The same columns should be hidden here too.
- Also test that the "Show all columns" and "Hide all columns" buttons
  work and that the changes persist across batches.

Comment 2 David Nind 2021-02-24 11:25:42 UTC

Created attachment 117244 [details] [review]
Bug 27751: Phase out jquery.cookie.js: Batch item modifications

To test, apply the patch and go to Tools -> Batch item modification.

- Submit a batch of barcodes for modification.
- Uncheck some checkboxes to hide columns in the table showing your
  submitted items.
- Return to the batch item modification page and submit your batch
  again.
- The columns you selected should still be hidden.
- Submit a batch of items for deletion.
- The same columns should be hidden here too.
- Also test that the "Show all columns" and "Hide all columns" buttons
  work and that the changes persist across batches.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Katrin Fischer 2021-03-04 14:16:18 UTC

Created attachment 117727 [details] [review]
Bug 27751: Phase out jquery.cookie.js: Batch item modifications

To test, apply the patch and go to Tools -> Batch item modification.

- Submit a batch of barcodes for modification.
- Uncheck some checkboxes to hide columns in the table showing your
  submitted items.
- Return to the batch item modification page and submit your batch
  again.
- The columns you selected should still be hidden.
- Submit a batch of items for deletion.
- The same columns should be hidden here too.
- Also test that the "Show all columns" and "Hide all columns" buttons
  work and that the changes persist across batches.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Jonathan Druart 2021-03-09 16:20:14 UTC

Pushed to master for 21.05, thanks to everybody involved!

Comment 5 Fridolin Somers 2021-03-19 13:25:54 UTC

Enhancement not pushed to 20.11.x