Following coding guideline JS8: "Follow guidelines set by ESLint," some errors should be corrected in batchMod.js.
Created attachment 117158 [details] [review] Bug 27752: Correct eslint errors in batchMod.js This patch makes minor changes to batchMod.js in order to address errors raised by ESLint. These changes include whitespace changes, so diff accordingly. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes for modification. - Uncheck some checkboxes to hide columns in the table showing your submitted items. - Return to the batch item modification page and submit your batch again. - The columns you selected should still be hidden. - Submit a batch of items for deletion. - The same columns should be hidden here too. To confirm that ESLint is happy with the changes you could open the file for editing using an editor with ESLint integration, or install ESLint on the command line: https://eslint.org/docs/user-guide/command-line-interface
Created attachment 117230 [details] [review] Bug 27752: Correct eslint errors in batchMod.js This patch makes minor changes to batchMod.js in order to address errors raised by ESLint. These changes include whitespace changes, so diff accordingly. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes for modification. - Uncheck some checkboxes to hide columns in the table showing your submitted items. - Return to the batch item modification page and submit your batch again. - The columns you selected should still be hidden. - Submit a batch of items for deletion. - The same columns should be hidden here too. To confirm that ESLint is happy with the changes you could open the file for editing using an editor with ESLint integration, or install ESLint on the command line: https://eslint.org/docs/user-guide/command-line-interface Signed-off-by: David Nind <david@davidnind.com>
No changes to behaviour after applying the patch and walking through the test plan. With the Atom text editor and the linter-eslint package the number of error and warnings goes from 134 to 0!
Created attachment 117726 [details] [review] Bug 27752: Correct eslint errors in batchMod.js This patch makes minor changes to batchMod.js in order to address errors raised by ESLint. These changes include whitespace changes, so diff accordingly. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes for modification. - Uncheck some checkboxes to hide columns in the table showing your submitted items. - Return to the batch item modification page and submit your batch again. - The columns you selected should still be hidden. - Submit a batch of items for deletion. - The same columns should be hidden here too. To confirm that ESLint is happy with the changes you could open the file for editing using an editor with ESLint integration, or install ESLint on the command line: https://eslint.org/docs/user-guide/command-line-interface Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.04
Pushed to 20.05.x for 20.05.10
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.