Summary: | background_jobs_worker.pl is memory inefficient | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, julian.maurice, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27782 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
Circulation function: | |||
Bug Depends on: | 22417 | ||
Bug Blocks: | 28413 | ||
Attachments: |
Bug 27756: Fork background jobs to prevent memory leak
Bug 27756: Fork background jobs to prevent memory leak Bug 27756: Fork background jobs to prevent memory leak |
Description
David Cook
2021-02-22 23:11:16 UTC
Some food for thought at https://stackoverflow.com/questions/9733146/tips-for-keeping-perl-memory-usage-low/9734699#9734699 Haha, I was thinking along the same lines as you! As an aside, I think forking would also resolve bug 27782 right? (In reply to Martin Renvoize from comment #2) > Haha, I was thinking along the same lines as you! There's a reason we're friends. Haha. > As an aside, I think forking would also resolve bug 27782 right? Yeah, it would resolve bug 27782 too. Double win. Created attachment 117500 [details] [review] Bug 27756: Fork background jobs to prevent memory leak Created attachment 119625 [details] [review] Bug 27756: Fork background jobs to prevent memory leak Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected to me.. but I'm not an expert in forking so look to someone more familiar with that for a QA. Signing off Created attachment 120661 [details] [review] Bug 27756: Fork background jobs to prevent memory leak Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 21.05, thanks to everybody involved! Do you think this should be pushed to 20.11.x ? *** Bug 27782 has been marked as a duplicate of this bug. *** |