Bug 27871

Summary: Make hold notes optionally visible in OPAC patron record
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: koha, noemie.labine
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12358
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 27870    
Bug Blocks:    

Description Andrew Fuerste-Henry 2021-03-04 19:31:50 UTC
We should add hold notes to the holds table in the patron account on the OPAC, but should make it hidden and un-toggle-able by default. This maintains the current default behavior (hold notes are not public-facing), but allows them to be made public if desired.
Comment 1 Katrin Fischer 2021-03-04 20:59:44 UTC
Hi Andrew, can you describe how this would be different to the current behaviour of the  OpacHoldNotes  system preference?

I think there is another bug around that I liked the idea of: split the hold notes into an internal and a public note. Would this be a viable alternative solution?
Comment 2 Andrew Fuerste-Henry 2021-03-04 21:05:32 UTC
Existing bug 12358 suggests splitting hold notes into public and non-public. I suggested this as a less complex alternative. While some libraries may want these notes visible while others do not, it's a whole other level of complexity to allow both options at once.

Turning on OpacHoldNotes allows patrons to enter notes when placing holds, but doesn't allow patrons to ever see those notes.
Comment 3 Katrin Fischer 2021-03-04 21:06:52 UTC
(In reply to Andrew Fuerste-Henry from comment #2)
> Existing bug 12358 suggests splitting hold notes into public and non-public.
> I suggested this as a less complex alternative. While some libraries may
> want these notes visible while others do not, it's a whole other level of
> complexity to allow both options at once.
> 
> Turning on OpacHoldNotes allows patrons to enter notes when placing holds,
> but doesn't allow patrons to ever see those notes.

Hm not sure I agree about complexity. It's anothre database field and visiblity would be much more straightforward than it's now - less likely to accidentally leak information or get in a state where you can't switch the pref because you have sensitive data in the notes or might have.
Comment 4 Andrew Fuerste-Henry 2021-03-04 21:08:14 UTC
Fair enough! I have no quarrel with the suggestion in bug 12358.
Comment 5 Katrin Fischer 2021-03-04 21:09:02 UTC
Just thinking loud - also happy to explore different ideas!
Comment 6 Owen Leonard 2022-03-03 15:03:05 UTC
*** Bug 30157 has been marked as a duplicate of this bug. ***