We should add hold notes to the holds table in the patron account on the OPAC, but should make it hidden and un-toggle-able by default. This maintains the current default behavior (hold notes are not public-facing), but allows them to be made public if desired.
Hi Andrew, can you describe how this would be different to the current behaviour of the OpacHoldNotes system preference? I think there is another bug around that I liked the idea of: split the hold notes into an internal and a public note. Would this be a viable alternative solution?
Existing bug 12358 suggests splitting hold notes into public and non-public. I suggested this as a less complex alternative. While some libraries may want these notes visible while others do not, it's a whole other level of complexity to allow both options at once. Turning on OpacHoldNotes allows patrons to enter notes when placing holds, but doesn't allow patrons to ever see those notes.
(In reply to Andrew Fuerste-Henry from comment #2) > Existing bug 12358 suggests splitting hold notes into public and non-public. > I suggested this as a less complex alternative. While some libraries may > want these notes visible while others do not, it's a whole other level of > complexity to allow both options at once. > > Turning on OpacHoldNotes allows patrons to enter notes when placing holds, > but doesn't allow patrons to ever see those notes. Hm not sure I agree about complexity. It's anothre database field and visiblity would be much more straightforward than it's now - less likely to accidentally leak information or get in a state where you can't switch the pref because you have sensitive data in the notes or might have.
Fair enough! I have no quarrel with the suggestion in bug 12358.
Just thinking loud - also happy to explore different ideas!
*** Bug 30157 has been marked as a duplicate of this bug. ***