Summary: | Move external search results links out of page heading | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bolshawh, kyle, martin.renvoize, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Bug Depends on: | 27740 | ||
Bug Blocks: | |||
Attachments: |
Bug 27882: Move external search results links out of page heading
Bug 27882: Move external search results links out of page heading Bug 27882: Move external search results links out of page heading |
Description
Owen Leonard
2021-03-05 15:18:13 UTC
Created attachment 117863 [details] [review] Bug 27882: Move external search results links out of page heading This patch modifies the JavaScript which adds search result information to the OPAC search results page which is returned from OverDrive, Recorded Books, or Open Library. The information now displays below the page heading instead of inside it. To test you must have OpenLibrarySearch enabled, OverDrive-related preferences populated (OverDriveClientKey, OverDriveClientSecret, OverDriveLibraryID), or RecordedBooks preferences (RecordedBooksClientSecret, RecordedBooksDomain, RecordedBooksLibraryID). This patch was written with OverDrive and Open Library results active. - Apply the patch and perform a search in the OPAC catalog. - On the search results page you should see results for your external services appear below the page heading ("You search returned..."), e.g. "Found 20257 results in the library's OpenLibrary collection" "Found 337 results in the library's OverDrive collection" Created attachment 120850 [details] [review] Bug 27882: Move external search results links out of page heading This patch modifies the JavaScript which adds search result information to the OPAC search results page which is returned from OverDrive, Recorded Books, or Open Library. The information now displays below the page heading instead of inside it. To test you must have OpenLibrarySearch enabled, OverDrive-related preferences populated (OverDriveClientKey, OverDriveClientSecret, OverDriveLibraryID), or RecordedBooks preferences (RecordedBooksClientSecret, RecordedBooksDomain, RecordedBooksLibraryID). This patch was written with OverDrive and Open Library results active. - Apply the patch and perform a search in the OPAC catalog. - On the search results page you should see results for your external services appear below the page heading ("You search returned..."), e.g. "Found 20257 results in the library's OpenLibrary collection" "Found 337 results in the library's OverDrive collection" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 120913 [details] [review] Bug 27882: Move external search results links out of page heading This patch modifies the JavaScript which adds search result information to the OPAC search results page which is returned from OverDrive, Recorded Books, or Open Library. The information now displays below the page heading instead of inside it. To test you must have OpenLibrarySearch enabled, OverDrive-related preferences populated (OverDriveClientKey, OverDriveClientSecret, OverDriveLibraryID), or RecordedBooks preferences (RecordedBooksClientSecret, RecordedBooksDomain, RecordedBooksLibraryID). This patch was written with OverDrive and Open Library results active. - Apply the patch and perform a search in the OPAC catalog. - On the search results page you should see results for your external services appear below the page heading ("You search returned..."), e.g. "Found 20257 results in the library's OpenLibrary collection" "Found 337 results in the library's OverDrive collection" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Looks good, no regressions. Passing QA Pushed to master for 21.11, thanks to everybody involved! Enhancement not backported to 21.05 |