When results are found in OverDrive, Recorded Books, or OpenLibrary collections the information is appended to the search results <h1>. I think the should be added just after the <h1> because they're not really part of the heading information.
Created attachment 117863 [details] [review] Bug 27882: Move external search results links out of page heading This patch modifies the JavaScript which adds search result information to the OPAC search results page which is returned from OverDrive, Recorded Books, or Open Library. The information now displays below the page heading instead of inside it. To test you must have OpenLibrarySearch enabled, OverDrive-related preferences populated (OverDriveClientKey, OverDriveClientSecret, OverDriveLibraryID), or RecordedBooks preferences (RecordedBooksClientSecret, RecordedBooksDomain, RecordedBooksLibraryID). This patch was written with OverDrive and Open Library results active. - Apply the patch and perform a search in the OPAC catalog. - On the search results page you should see results for your external services appear below the page heading ("You search returned..."), e.g. "Found 20257 results in the library's OpenLibrary collection" "Found 337 results in the library's OverDrive collection"
Created attachment 120850 [details] [review] Bug 27882: Move external search results links out of page heading This patch modifies the JavaScript which adds search result information to the OPAC search results page which is returned from OverDrive, Recorded Books, or Open Library. The information now displays below the page heading instead of inside it. To test you must have OpenLibrarySearch enabled, OverDrive-related preferences populated (OverDriveClientKey, OverDriveClientSecret, OverDriveLibraryID), or RecordedBooks preferences (RecordedBooksClientSecret, RecordedBooksDomain, RecordedBooksLibraryID). This patch was written with OverDrive and Open Library results active. - Apply the patch and perform a search in the OPAC catalog. - On the search results page you should see results for your external services appear below the page heading ("You search returned..."), e.g. "Found 20257 results in the library's OpenLibrary collection" "Found 337 results in the library's OverDrive collection" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 120913 [details] [review] Bug 27882: Move external search results links out of page heading This patch modifies the JavaScript which adds search result information to the OPAC search results page which is returned from OverDrive, Recorded Books, or Open Library. The information now displays below the page heading instead of inside it. To test you must have OpenLibrarySearch enabled, OverDrive-related preferences populated (OverDriveClientKey, OverDriveClientSecret, OverDriveLibraryID), or RecordedBooks preferences (RecordedBooksClientSecret, RecordedBooksDomain, RecordedBooksLibraryID). This patch was written with OverDrive and Open Library results active. - Apply the patch and perform a search in the OPAC catalog. - On the search results page you should see results for your external services appear below the page heading ("You search returned..."), e.g. "Found 20257 results in the library's OpenLibrary collection" "Found 337 results in the library's OverDrive collection" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Looks good, no regressions. Passing QA
Pushed to master for 21.11, thanks to everybody involved!
Enhancement not backported to 21.05