Summary: | Authority linking broken in advanced editor | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Cataloging | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | abl, aleisha, alexis.ripetti, andrew, black23, caroline.cyr-la-rose, dcook, eric.begin, fcapovilla, fpichenot, frank.hansen, fridolin.somers, jonathan.druart, joonas.kylmala, josef.moravec, m.de.rooy, marjorie.barry-vila, martin.renvoize, mtompset, niamh.walker-headon, nick, nicolas.bravais, patrick.robitaille, phil, philippe.blouin, r.delahunty, testopia, vanoudt, verolencinas |
Version: | Main | Keywords: | Manual, regression |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
Circulation function: | |||
Bug Depends on: | 11299 | ||
Bug Blocks: | |||
Attachments: |
Bug 27886: Move non-rancor code into correct section
Bug 27886: Move non-rancor code into correct section Bug 27886: Move non-rancor code into correct section |
Description
Owen Leonard
2021-03-05 18:51:23 UTC
I can confirm the broken behaviour. Created attachment 117886 [details] [review] Bug 27886: Move non-rancor code into correct section The template was including code that was not compatible with Rancor, moving the end of the conditional seems to fix the error To test: 1 - Open a record in the advanced catalog editor 2 - Create or edit a 100 field with some content, I used 'bruce' 3 - Press Ctrl+shift+l to launch authority search 4 - Perform a search and select an authority 5 - Note the field copies but the pop-ups don't close 6 - Apply patch 7 - Reload the page 8 - Repeat 1-4 9 - The field copies and the windows close Created attachment 117887 [details] [review] Bug 27886: Move non-rancor code into correct section The template was including code that was not compatible with Rancor, moving the end of the conditional seems to fix the error To test: 1 - Open a record in the advanced catalog editor 2 - Create or edit a 100 field with some content, I used 'bruce' 3 - Press Ctrl+shift+l to launch authority search 4 - Perform a search and select an authority 5 - Note the field copies but the pop-ups don't close 6 - Apply patch 7 - Reload the page 8 - Repeat 1-4 9 - The field copies and the windows close Signed-off-by: David Nind <david@davidnind.com> Created attachment 117889 [details] [review] Bug 27886: Move non-rancor code into correct section The template was including code that was not compatible with Rancor, moving the end of the conditional seems to fix the error To test: 1 - Open a record in the advanced catalog editor 2 - Create or edit a 100 field with some content, I used 'bruce' 3 - Press Ctrl+shift+l to launch authority search 4 - Perform a search and select an authority 5 - Note the field copies but the pop-ups don't close 6 - Apply patch 7 - Reload the page 8 - Repeat 1-4 9 - The field copies and the windows close Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 21.05, thanks to everybody involved! |