In the advanced MARC editor, the keyboard shortcut Ctrl-Shift-L triggers a popup where you can search for an authority record. Select a result from that window doesn't work to populate the field in the editor. The pop-up window which uses blinddetail-biblio-search.tt triggers a JavaScript error and never closes. git bisect blames Bug 11299
I can confirm the broken behaviour.
Created attachment 117886 [details] [review] Bug 27886: Move non-rancor code into correct section The template was including code that was not compatible with Rancor, moving the end of the conditional seems to fix the error To test: 1 - Open a record in the advanced catalog editor 2 - Create or edit a 100 field with some content, I used 'bruce' 3 - Press Ctrl+shift+l to launch authority search 4 - Perform a search and select an authority 5 - Note the field copies but the pop-ups don't close 6 - Apply patch 7 - Reload the page 8 - Repeat 1-4 9 - The field copies and the windows close
Created attachment 117887 [details] [review] Bug 27886: Move non-rancor code into correct section The template was including code that was not compatible with Rancor, moving the end of the conditional seems to fix the error To test: 1 - Open a record in the advanced catalog editor 2 - Create or edit a 100 field with some content, I used 'bruce' 3 - Press Ctrl+shift+l to launch authority search 4 - Perform a search and select an authority 5 - Note the field copies but the pop-ups don't close 6 - Apply patch 7 - Reload the page 8 - Repeat 1-4 9 - The field copies and the windows close Signed-off-by: David Nind <david@davidnind.com>
Created attachment 117889 [details] [review] Bug 27886: Move non-rancor code into correct section The template was including code that was not compatible with Rancor, moving the end of the conditional seems to fix the error To test: 1 - Open a record in the advanced catalog editor 2 - Create or edit a 100 field with some content, I used 'bruce' 3 - Press Ctrl+shift+l to launch authority search 4 - Perform a search and select an authority 5 - Note the field copies but the pop-ups don't close 6 - Apply patch 7 - Reload the page 8 - Repeat 1-4 9 - The field copies and the windows close Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Depends on Bug 11299 not in 20.11.x