Summary: | Move _escape_* functions from acq/parcel.tt to be re-usable | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, jonathan.druart, joonas.kylmala, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement moves the useful `_escape_price` and `_escape_str` functions found in acq/parcel.tt into the re-usable staff-global.js include file.
|
Version(s) released in: |
21.05.00,20.11.04
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 26273 | ||
Attachments: |
Bug 27930: Move _escape_* from acqui/parcel.tt to js/staff-global.js
Bug 27930: Move _escape_* from acqui/parcel.tt to js/staff-global.js Bug 27930: [stables] Move _escape_* from acqui/parcel.tt to js/staff-global.js |
Description
Martin Renvoize (ashimema)
2021-03-11 14:20:29 UTC
Created attachment 118128 [details] [review] Bug 27930: Move _escape_* from acqui/parcel.tt to js/staff-global.js This patch moves the _escape_str and _escape_price functions into the staff-global.js include Test plan 1/ The acquisitions parcel page should look the same before and after the patch. 2/ Signoff Created attachment 118153 [details] [review] Bug 27930: Move _escape_* from acqui/parcel.tt to js/staff-global.js This patch moves the _escape_str and _escape_price functions into the staff-global.js include Test plan 1/ The acquisitions parcel page should look the same before and after the patch. 2/ Signoff Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 21.05, thanks to everybody involved! Created attachment 118154 [details] [review] Bug 27930: [stables] Move _escape_* from acqui/parcel.tt to js/staff-global.js This patch moves the _escape_str and _escape_price functions into the staff-global.js include Test plan 1/ The acquisitions parcel page should look the same before and after the patch. 2/ Signoff Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Note: For stable branch the functions didn't exist. RMaints, I would recommend you to pick this one to anticipate a call to a missing function when backporting a patch. (In reply to Jonathan Druart from comment #5) > RMaints, I would recommend you to pick this one to anticipate a call to a > missing function when backporting a patch. Good point. Ah but _escape_* methods have been added by Bug 20212 not backported, that why there is a "stable" patch. OK Pushed to 20.11.x for 20.11.04 Not backported to 20.05 |