| Summary: | Fix plural handling for AUTO_RENEWALS_DGST message | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Agustín Moyano <agustinmoyano> |
| Component: | Circulation | Assignee: | Agustín Moyano <agustinmoyano> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | clackman, gmcharlt, kyle.m.hall, r.delahunty |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 18532, 27829 | ||
| Bug Blocks: | |||
|
Description
Agustín Moyano
2021-03-16 15:25:25 UTC
Suggested language for the renewal message: "N item(s) successfully renewed" (so it works for one or more items, and doesn't have to deal with verb tenses). Suggested language for the notification of the number of items that did not renew: - "[% error %] item(s) did not renew." We have this resolved in a way we like. The perfect notice (see bug 36109) would include counters like the DGST has as we'd like to deal with plural / singular problems in all notices. Here is an extract from our DGST and you can see a screengrab of our full digest in the other bug: <b>Renewal summary:</b><br/> [% IF success AND success ==1 %] [% success %] item was renewed. [% ELSIF success AND success >1 %] [% success %] items were renewed. [% END %]<br/> [% IF error AND error ==1 %][% error %] item was not renewed. It is now overdue and must be returned.<br/><br/> […] [% ELSIF error AND error >1 %][% error %] items were not renewed. They are now overdue and must be returned.<br/> […] |