Bug 27966 - Fix plural handling for AUTO_RENEWALS_DGST message
Summary: Fix plural handling for AUTO_RENEWALS_DGST message
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Agustín Moyano
QA Contact: Testopia
URL:
Keywords:
Depends on: 18532 27829
Blocks:
  Show dependency tree / graph
 
Reported: 2021-03-16 15:25 UTC by Agustín Moyano
Modified: 2024-10-18 08:14 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agustín Moyano 2021-03-16 15:25:25 UTC 
AUTO_RENEWALS_DGST does not handle properly plural vs singular error and success messages.
Comment 1 Cheryl 2021-03-16 15:44:16 UTC 
Suggested language for the renewal message: "N item(s) successfully renewed" (so it works for one or more items, and doesn't have to deal with verb tenses).
Comment 2 Cheryl 2021-03-16 15:58:02 UTC 
Suggested language for the notification of the number of items that did not renew: 
- "[% error %] item(s) did not renew."
Comment 3 Ray Delahunty 2024-10-18 08:14:21 UTC 
We have this resolved in a way we like. The perfect notice (see bug 36109) would include counters like the DGST has as we'd like to deal with plural / singular problems in all notices. Here is an extract from our DGST and you can see a screengrab of our full digest in the other bug:

<b>Renewal summary:</b><br/>
[% IF success AND success ==1 %] [% success %] item was renewed. [% ELSIF success AND success >1 %] [% success %] items were renewed. 
[% END %]<br/>
[% IF error AND error ==1 %][% error %] item was not renewed. It is now overdue and must be returned.<br/><br/>
[…]
[% ELSIF error AND error >1 %][% error %] items were not renewed. They are now overdue and must be returned.<br/>
[…]