Summary: | process_message_queue.pl missing `use Try::Tiny` | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall <kyle> |
Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall <kyle> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrewfh, dcook, fridolin.somers, martin.renvoize, nick, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06,20.05.12
|
|
Bug Depends on: | 24183 | ||
Bug Blocks: | |||
Attachments: |
Bug 28221 - Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it
Bug 28221: Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it |
Description
Kyle M Hall
2021-04-26 10:35:37 UTC
Created attachment 120169 [details] [review] Bug 28221 - Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it The message queue processor has a try/catch block, but does not have a 'use Try::Tiny' line. Because of this the following error ocurrs if an instance has any plugins installed that use the before_send_messages hook: Can't locate object method "catch" via package "1" (perhaps you forgot to load "1"?) at /usr/share/koha/bin/cronjobs/process_message_queue.pl line 86. Test Plan: 1) Install a plugin that uses the before_send_messages hook 2) Run the message queue processor 3) Note the error message 4) Apply this patch 5) Run the message queue processor again 6) No error! Created attachment 120174 [details] [review] Bug 28221: Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it The message queue processor has a try/catch block, but does not have a 'use Try::Tiny' line. Because of this the following error ocurrs if an instance has any plugins installed that use the before_send_messages hook: Can't locate object method "catch" via package "1" (perhaps you forgot to load "1"?) at /usr/share/koha/bin/cronjobs/process_message_queue.pl line 86. Test Plan: 1) Install a plugin that uses the before_send_messages hook 2) Run the message queue processor 3) Note the error message 4) Apply this patch 5) Run the message queue processor again 6) No error! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial fix.. oops. Passing QA Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Suggestion for a title change would be "proces_mesage_queue.pl missing Try::Tiny use statement" or "proces_mesage_queue.pl not loading Try::Tiny". Not a big deal but might just be clearer for release notes. Pushed to 20.05.x for 20.05.12 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |