Bug 28233

Summary: Backport removal of excess opaccredits div
Product: Koha Reporter: Mark Tompsett <mtompset>
Component: OPACAssignee: Mark Tompsett <mtompset>
Status: CLOSED FIXED QA Contact: Kyle M Hall (khall) <kyle>
Severity: minor    
Priority: P5 - low CC: andrew, jonathan.druart, kyle, lucas
Version: 20.05   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 28233: Backport removal of excess opaccredits div
Bug 28233: Backport removal of excess opaccredits div
Bug 28233: Backport removal of excess opaccredits div

Description Mark Tompsett 2021-04-27 01:55:03 UTC
This is for a backport to 20.05, as it was fixed in 20.11, but bug 20168 was too grand to back port to 20.05.

Put something in the opaccredits news item, and opaccredits outputs 2 divs, because one is in the the template, and one is in the TT function that puts out the opaccredits news block.

Test Plan
---------
1. Do a search
2. Look at opac details for any result.
3. View page source
4. Find opaccredits
5. See two opaccredits divs
6. Apply patch
7. Repeat steps 1-4
8. hope that memcached or something else does not makes it appear,
     but you should not see two opaccredits divs.
9. sign off. :)
Comment 1 Mark Tompsett 2021-04-27 02:02:50 UTC
Created attachment 120189 [details] [review]
Bug 28233: Backport removal of excess opaccredits div

This is for a backport to 20.05, as it was fixed in 20.11, but bug 20168 was too grand to back port to 20.05.

Put something in the opaccredits news item, and opaccredits outputs 2 divs, because one is in the the template, and one is in the TT function that puts out the opaccredits news block.

Test Plan
---------
1. Do a search
2. Look at opac details for any result.
3. View page source
4. Find opaccredits
5. See two opaccredits divs
6. Apply patch
7. Repeat steps 1-4
8. hope that memcached or something else does not makes it appear,
     but you should not see two opaccredits divs.
9. sign off. :)
Comment 2 Owen Leonard 2021-04-27 10:36:21 UTC
Created attachment 120208 [details] [review]
Bug 28233: Backport removal of excess opaccredits div

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Kyle M Hall (khall) 2021-05-07 16:33:51 UTC
Created attachment 120706 [details] [review]
Bug 28233: Backport removal of excess opaccredits div

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Jonathan Druart 2021-05-10 08:29:39 UTC
Sending to 20.05 queue.