This is for a backport to 20.05, as it was fixed in 20.11, but bug 20168 was too grand to back port to 20.05. Put something in the opaccredits news item, and opaccredits outputs 2 divs, because one is in the the template, and one is in the TT function that puts out the opaccredits news block. Test Plan --------- 1. Do a search 2. Look at opac details for any result. 3. View page source 4. Find opaccredits 5. See two opaccredits divs 6. Apply patch 7. Repeat steps 1-4 8. hope that memcached or something else does not makes it appear, but you should not see two opaccredits divs. 9. sign off. :)
Created attachment 120189 [details] [review] Bug 28233: Backport removal of excess opaccredits div This is for a backport to 20.05, as it was fixed in 20.11, but bug 20168 was too grand to back port to 20.05. Put something in the opaccredits news item, and opaccredits outputs 2 divs, because one is in the the template, and one is in the TT function that puts out the opaccredits news block. Test Plan --------- 1. Do a search 2. Look at opac details for any result. 3. View page source 4. Find opaccredits 5. See two opaccredits divs 6. Apply patch 7. Repeat steps 1-4 8. hope that memcached or something else does not makes it appear, but you should not see two opaccredits divs. 9. sign off. :)
Created attachment 120208 [details] [review] Bug 28233: Backport removal of excess opaccredits div Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 120706 [details] [review] Bug 28233: Backport removal of excess opaccredits div Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Sending to 20.05 queue.