|
Description
Inkeri Hakulinen
2021-04-30 12:04:27 UTC
+1 Created attachment 133782 [details] [review] Bug 28269: Add new system preference SearchWithISSNVariations Created attachment 133796 [details] [review] Bug 28269: Add new system preference SearchWithISSNVariations Created attachment 133869 [details] [review] Bug 28269: Add new system preference SearchWithISSNVariations Created attachment 133870 [details] [review] Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set Created attachment 133871 [details] [review] Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off Hi Slava, thx for your patches! I haven't tested yet, but looking at this, I wonder if it's not actually 2 great features :) We try to break things into small steps wherever possible, so I wonder if it would make sense to move your first patch to bug 23919 and link them both with a depends on (that will ensure the right sequence in testing). It will also have the benefit of this showing up more clearly in release notes. Hi Katrin, Okay, I'll deal with these issues. Let us know if we can help in any way :) The first patch (133869) will not solve by itself 23919 - there is additional code logic required (and I now have some proof of concept working, so yes, 23919 will be solved as well by me, but there will be another patch over 133869), and the above patch (133869) is needed by both 28269 and 23919. So it can be here or there. Q1: so to which ticket is better to place the first patch, please advise, Q2: Can I put one ticket as dependant on another, and that will fit? Ok, I will move patch 133869 to 23919 Created attachment 134386 [details] [review] Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set Created attachment 134387 [details] [review] Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off Created attachment 134427 [details] [review] Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set Created attachment 134428 [details] [review] Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off Created attachment 138185 [details] [review] Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu> Created attachment 138186 [details] [review] Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu> Created attachment 138850 [details] [review] Bug 28269: Add feature to search Acquisitions Orders by ISSN - add search form field for ISSN number - add search logic including ISSN variations search if SearchWithISSNVariations preference is set Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 138851 [details] [review] Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 138852 [details] [review] Bug 28269: (QA follow-up) Fix typo in test description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice enhancement :) Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be backported to 22.05.x series |