Bug 28269 - Order search should be possible with ISSN too
Summary: Order search should be possible with ISSN too
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Slava Shishkin
QA Contact: Testopia
URL:
Keywords:
Depends on: 23919
Blocks:
  Show dependency treegraph
 
Reported: 2021-04-30 12:04 UTC by Inkeri Hakulinen
Modified: 2023-12-28 20:42 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/659
Text to go in the release notes:
This adds ISSN as a new search option to the acquisitions advanced search form. If SearchWithISSNVariations is enabled, you'll be able to search for the ISSN with and without the hyphen.
Version(s) released in:
22.11.00


Attachments
Bug 28269: Add new system preference SearchWithISSNVariations (3.50 KB, patch)
2022-04-25 13:32 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 28269: Add new system preference SearchWithISSNVariations (3.50 KB, patch)
2022-04-25 14:02 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 28269: Add new system preference SearchWithISSNVariations (3.50 KB, patch)
2022-04-26 09:56 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 28269: Add feature to search Acquisitions Orders by ISSN (3.52 KB, patch)
2022-04-26 09:57 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off (3.60 KB, patch)
2022-04-26 09:57 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 28269: Add feature to search Acquisitions Orders by ISSN (3.52 KB, patch)
2022-04-29 13:33 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 28269: Add tests for Acquisitions Orders search by ISSN also with SearchWithISSNVariations on and off (3.60 KB, patch)
2022-04-29 13:33 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 28269: Add feature to search Acquisitions Orders by ISSN (3.52 KB, patch)
2022-04-29 20:08 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 28269: Add tests for Acquisitions Orders search by ISSN (3.60 KB, patch)
2022-04-29 20:08 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 28269: Add feature to search Acquisitions Orders by ISSN (3.58 KB, patch)
2022-07-27 16:49 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 28269: Add tests for Acquisitions Orders search by ISSN (3.66 KB, patch)
2022-07-27 16:50 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 28269: Add feature to search Acquisitions Orders by ISSN (3.63 KB, patch)
2022-08-08 19:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28269: Add tests for Acquisitions Orders search by ISSN (3.71 KB, patch)
2022-08-08 19:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28269: (QA follow-up) Fix typo in test description (996 bytes, patch)
2022-08-08 19:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Inkeri Hakulinen 2021-04-30 12:04:27 UTC
At the order search ( koha/acqui/histsearch.pl ) there should be a possibility to search orders by ISSN. Serials don't have an ISBN, but ISSN. Often the serial names are long and similar to each other, so the short and exact searching by ISSN should be an option, too.
Comment 1 Katrin Fischer 2021-06-03 21:23:29 UTC
+1
Comment 2 Slava Shishkin 2022-04-25 13:32:41 UTC Comment hidden (obsolete)
Comment 3 Slava Shishkin 2022-04-25 14:02:08 UTC Comment hidden (obsolete)
Comment 4 Slava Shishkin 2022-04-26 09:56:55 UTC Comment hidden (obsolete)
Comment 5 Slava Shishkin 2022-04-26 09:57:00 UTC Comment hidden (obsolete)
Comment 6 Slava Shishkin 2022-04-26 09:57:04 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2022-04-26 11:30:33 UTC
Hi Slava, thx for your patches! 

I haven't tested yet, but looking at this, I wonder if it's not actually 2 great features :) We try to break things into small steps wherever possible, so I wonder if it would make sense to move your first patch to bug 23919 and link them both with a depends on (that will ensure the right sequence in testing).

It will also have the benefit of this showing up more clearly in release notes.
Comment 8 Slava Shishkin 2022-04-26 12:19:39 UTC
Hi Katrin,
Okay, I'll deal with these issues.
Comment 9 Katrin Fischer 2022-04-26 12:23:04 UTC
Let us know if we can help in any way :)
Comment 10 Slava Shishkin 2022-04-26 19:49:40 UTC
The first patch (133869) will not solve by itself 23919 - there is additional code logic required (and I now have some proof of concept working, so yes, 23919 will be solved as well by me, but there will be another patch over 133869),

and the above patch (133869) is needed by both 28269 and 23919.
So it can be here or there.

Q1: so to which ticket is better to place the first patch, please advise,

Q2: Can I put one ticket as dependant on another, and that will fit?
Comment 11 Slava Shishkin 2022-04-26 20:36:53 UTC
Ok, I will move patch 133869 to 23919
Comment 12 Slava Shishkin 2022-04-29 13:33:30 UTC Comment hidden (obsolete)
Comment 13 Slava Shishkin 2022-04-29 13:33:34 UTC Comment hidden (obsolete)
Comment 14 Slava Shishkin 2022-04-29 20:08:05 UTC
Created attachment 134427 [details] [review]
Bug 28269: Add feature to search Acquisitions Orders by ISSN

- add search form field for ISSN number
- add search logic including ISSN variations search
  if SearchWithISSNVariations preference is set
Comment 15 Slava Shishkin 2022-04-29 20:08:10 UTC
Created attachment 134428 [details] [review]
Bug 28269: Add tests for Acquisitions Orders search by ISSN

also with SearchWithISSNVariations on and off
Comment 16 ByWater Sandboxes 2022-07-27 16:49:58 UTC
Created attachment 138185 [details] [review]
Bug 28269: Add feature to search Acquisitions Orders by ISSN

- add search form field for ISSN number
- add search logic including ISSN variations search
  if SearchWithISSNVariations preference is set

Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu>
Comment 17 ByWater Sandboxes 2022-07-27 16:50:05 UTC
Created attachment 138186 [details] [review]
Bug 28269: Add tests for Acquisitions Orders search by ISSN

also with SearchWithISSNVariations on and off

Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu>
Comment 18 Katrin Fischer 2022-08-08 19:30:06 UTC
Created attachment 138850 [details] [review]
Bug 28269: Add feature to search Acquisitions Orders by ISSN

- add search form field for ISSN number
- add search logic including ISSN variations search
  if SearchWithISSNVariations preference is set

Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 19 Katrin Fischer 2022-08-08 19:30:11 UTC
Created attachment 138851 [details] [review]
Bug 28269: Add tests for Acquisitions Orders search by ISSN

also with SearchWithISSNVariations on and off

Signed-off-by: KIT Library Germany <michaela.sieber@kit.edu>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 20 Katrin Fischer 2022-08-08 19:30:18 UTC
Created attachment 138852 [details] [review]
Bug 28269: (QA follow-up) Fix typo in test description

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 21 Katrin Fischer 2022-08-08 19:30:57 UTC
Nice enhancement :)
Comment 22 Tomás Cohen Arazi 2022-08-09 12:03:01 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 23 Lucas Gass 2022-09-30 22:40:27 UTC
Enhancement will not be backported to 22.05.x series