| Summary: | PopupMARCFieldDoc is defined twice in addbiblio.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Staff interface | Assignee: | Philip Orr <philip.orr> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | danyonsewell, gmcharlt, lucas, philip.orr |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06,22.05.14,21.11.22
|
|
| Circulation function: | |||
| Attachments: |
Bug #28315: Remove duplicate function definition
Bug 28315: Remove duplicate function definition Bug 28315: Remove duplicate function definition |
||
|
Description
Martin Renvoize (ashimema)
2021-05-11 07:58:58 UTC
Created attachment 150183 [details] [review] Bug #28315: Remove duplicate function definition This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt. To test: 1. Apply the patch 2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc 3. Navigate to "Cataloging" -> "Add MARC record" 4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab Created attachment 150216 [details] [review] Bug 28315: Remove duplicate function definition This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt. To test: 1. Apply the patch 2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc 3. Navigate to "Cataloging" -> "Add MARC record" 4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 150366 [details] [review] Bug 28315: Remove duplicate function definition This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt. To test: 1. Apply the patch 2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc 3. Navigate to "Cataloging" -> "Add MARC record" 4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Backported to 22.05.x for upcoming 22.05.14 Backported to 21.11.x for upcoming 21.11.22 |