Bug 28318

Summary: accounlintes.credit_number missing on the API
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: REST APIAssignee: Martin Renvoize <martin.renvoize>
Status: ASSIGNED --- QA Contact:
Severity: enhancement    
Priority: P5 - low    
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19036, 28272    
Bug Blocks: 14825    

Description Tomás Cohen Arazi 2021-05-11 11:33:51 UTC
It was added to the DB structure, but bug 28272 skipped it so we could ponder if it is required on the API object and how should we name it. Feels like 'credit_sequence_number' could be a good name for it.
Comment 1 Tomás Cohen Arazi 2021-05-11 11:36:20 UTC
Work to be done:
- Assing a field name mapping in Koha::Account::Line->to_api_mapping
- Add to the spec

The reason I didn't just propose to add it, is because it seems that credits are the only ones that should include it (maybe the same for cash_register_id?) and it then involves overloading Koha::Account::Line->to_api
Comment 2 Tomás Cohen Arazi 2021-05-11 11:38:59 UTC
Work to be done:
- Assing a field name mapping in Koha::Account::Line->to_api_mapping
- Add to the spec

The reason I didn't just propose to add it, is because it seems that credits are the only ones that should include it (maybe the same for cash_register_id?) and it then involves overloading Koha::Account::Line->to_api