Bug 28318 - accounlintes.credit_number missing on the API
Summary: accounlintes.credit_number missing on the API
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact:
URL:
Keywords:
Depends on: 19036 28272
Blocks: 14825
  Show dependency tree / graph
 
Reported: 2021-05-11 11:33 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2021-05-14 10:26 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2021-05-11 11:33:51 UTC 
It was added to the DB structure, but bug 28272 skipped it so we could ponder if it is required on the API object and how should we name it. Feels like 'credit_sequence_number' could be a good name for it.
Comment 1 Tomás Cohen Arazi (tcohen) 2021-05-11 11:36:20 UTC 
Work to be done:
- Assing a field name mapping in Koha::Account::Line->to_api_mapping
- Add to the spec

The reason I didn't just propose to add it, is because it seems that credits are the only ones that should include it (maybe the same for cash_register_id?) and it then involves overloading Koha::Account::Line->to_api
Comment 2 Tomás Cohen Arazi (tcohen) 2021-05-11 11:38:59 UTC 
Work to be done:
- Assing a field name mapping in Koha::Account::Line->to_api_mapping
- Add to the spec

The reason I didn't just propose to add it, is because it seems that credits are the only ones that should include it (maybe the same for cash_register_id?) and it then involves overloading Koha::Account::Line->to_api