Summary: | Patron attributes no longer have option to select empty class | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, gmcharlt, jonathan.druart, kyle, tomascohen, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.06,20.05.12
|
|
Circulation function: | |||
Bug Depends on: | 20443 | ||
Bug Blocks: | 28347 | ||
Attachments: |
Bug 28345: Patron attributes no longer have option to select empty class
Bug 28345: Patron attributes no longer have option to select empty class Bug 28345: Patron attributes no longer have option to select empty class |
Description
Owen Leonard
2021-05-13 10:38:21 UTC
Created attachment 120916 [details] [review] Bug 28345: Patron attributes no longer have option to select empty class This patch adds the "empty" parameter to the PROCESS directive which builds the "Class" dropdown. This allows the user to choose a blank option when creating or editing a patron attribute. To test, apply the patch and go to Administration -> Patron attribute types -> Add patron attribute type. In the entry form the "Class" dropdown should have a blank option. When editing an existing attribute with a class defined, the correct class should still be preselected. Created attachment 120918 [details] [review] Bug 28345: Patron attributes no longer have option to select empty class This patch adds the "empty" parameter to the PROCESS directive which builds the "Class" dropdown. This allows the user to choose a blank option when creating or editing a patron attribute. To test, apply the patch and go to Administration -> Patron attribute types -> Add patron attribute type. In the entry form the "Class" dropdown should have a blank option. When editing an existing attribute with a class defined, the correct class should still be preselected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 120945 [details] [review] Bug 28345: Patron attributes no longer have option to select empty class This patch adds the "empty" parameter to the PROCESS directive which builds the "Class" dropdown. This allows the user to choose a blank option when creating or editing a patron attribute. To test, apply the patch and go to Administration -> Patron attribute types -> Add patron attribute type. In the entry form the "Class" dropdown should have a blank option. When editing an existing attribute with a class defined, the correct class should still be preselected. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.06 Pushed to 20.05.x for 20.05.12 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |