Bug 28347

Summary:	Add DataTables, additional information to patron attribute types management
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	System Administration	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Nick Clemens (kidclamp) <nick>
Severity:	enhancement
Priority:	P5 - low	CC:	gmcharlt, kyle, nick
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	21.11.00
Circulation function:
Bug Depends on:	28345
Bug Blocks:
Attachments:	Bug 28347: Add DataTables, additional information to patron attribute types management Bug 28347: Add DataTables, additional information to patron attribute types management Bug 28347: Add DataTables, additional information to patron attribute types management

Description Owen Leonard 2021-05-13 11:05:29 UTC

I'd like to make some enhancements to the patron attribute types management page:

- Add DataTable features
- Add authorized value category and mandatory information to the tables
- Correct "branch" to "library"

Comment 1 Owen Leonard 2021-05-13 12:08:54 UTC

Created attachment 120922 [details] [review]
Bug 28347: Add DataTables, additional information to patron attribute types management

This patch enhances the display of patron attribute information on the
attribute management page.

To test, apply the patch and go to Administration -> Patron attribute
types.

 - If necessary, add multiple patron attributes so that there is data to
   display. Include:
   - Some which are mandatory
   - Some which are linked to an authorized value category
   - Some which share a class.
 - The tables showing your attributes should each have DataTables
   sorting and controls (except for column configuration, which isn't
   added by this patch).
 - Confirm that DataTable controls work correctly for each table.
 - The table should include columns showing authorized value category
   and whether the attribute is mandatory.
 - If you are logged in as a user with permission to manage
   authorized values, the data in the authorized value category
   column should be linked to that category on the authorized values
   page.

Comment 2 David Nind 2021-05-16 21:00:20 UTC

Created attachment 121020 [details] [review]
Bug 28347: Add DataTables, additional information to patron attribute types management

This patch enhances the display of patron attribute information on the
attribute management page.

To test, apply the patch and go to Administration -> Patron attribute
types.

 - If necessary, add multiple patron attributes so that there is data to
   display. Include:
   - Some which are mandatory
   - Some which are linked to an authorized value category
   - Some which share a class.
 - The tables showing your attributes should each have DataTables
   sorting and controls (except for column configuration, which isn't
   added by this patch).
 - Confirm that DataTable controls work correctly for each table.
 - The table should include columns showing authorized value category
   and whether the attribute is mandatory.
 - If you are logged in as a user with permission to manage
   authorized values, the data in the authorized value category
   column should be linked to that category on the authorized values
   page.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Nick Clemens (kidclamp) 2021-07-23 14:40:38 UTC

Created attachment 123126 [details] [review]
Bug 28347: Add DataTables, additional information to patron attribute types management

This patch enhances the display of patron attribute information on the
attribute management page.

To test, apply the patch and go to Administration -> Patron attribute
types.

 - If necessary, add multiple patron attributes so that there is data to
   display. Include:
   - Some which are mandatory
   - Some which are linked to an authorized value category
   - Some which share a class.
 - The tables showing your attributes should each have DataTables
   sorting and controls (except for column configuration, which isn't
   added by this patch).
 - Confirm that DataTable controls work correctly for each table.
 - The table should include columns showing authorized value category
   and whether the attribute is mandatory.
 - If you are logged in as a user with permission to manage
   authorized values, the data in the authorized value category
   column should be linked to that category on the authorized values
   page.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 4 Jonathan Druart 2021-07-26 10:47:43 UTC

Pushed to master for 21.11, thanks to everybody involved!

Comment 5 Kyle M Hall (khall) 2021-07-30 16:15:11 UTC

Enhancement not backported for 21.05