Summary: | Invalid value of OpacHiddenItems crashes OPAC search | ||
---|---|---|---|
Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
Component: | Searching | Assignee: | Bugs List <koha-bugs> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 24403 |
Description
Victor Grousset/tuxayo
2021-05-16 22:05:50 UTC
The about page warning is not likely to be found when hitting the issue. But that can still help. And we have other fish to fry. If somebody wants to make it easier to find the cause the OPAC search crash, they can send a patch here. Anyway, «damaged: 1» doesn't trigger the warning ^^" filter_by_visible_in_opac and GetHiddenItemnumbers have different behaviours: From GetHiddenItemnumbers: if (any { $val eq $_ } @{$hidingrules->{$field}}) { Expect an array (damaged: [1]) From filter_by_visible_in_opac: { '-not_in' => $rules->{$field} } will work for array and scalar GetHiddenItemnumbers must be removed anyway. This is no longer valid since bug 23583. *** This bug has been marked as a duplicate of bug 23583 *** (In reply to Jonathan Druart from comment #3) > filter_by_visible_in_opac and GetHiddenItemnumbers have different behaviours: > > > From GetHiddenItemnumbers: > if (any { $val eq $_ } @{$hidingrules->{$field}}) { > Expect an array (damaged: [1]) > > From filter_by_visible_in_opac: > { '-not_in' => $rules->{$field} } > will work for array and scalar This is true: it is an unadvertised side-effect of considering the OpacHiddenItems syspref YAML, and not just a subset of YAML. |