From bug 15448, we're now checking OPACHiddenItems to see if something is hidden before we allow a hold on it. However, the manner in which that check is performed causes a problem if the syspref contains incorrect values. To recreate: - make sure OPACHiddenItems is empty - find a holdable item on the OPAC, confirm you can place a hold on it - enter "itemlost: [AB]" in OPACHiddenItems (an incorrect value because itemlost can only contain 1 bit) - confirm your item is not hidden from the OPAC but you are told it is not available for holds You'll see the same behavior if you use an incorrect field name, like "lost" or "itemtype."
Created attachment 119513 [details] [review] Bug 28125: Display a warning on the about page for OPACHiddenItems is needed If OPACHiddenItems is containing badly construct it will lead to inconsistent behaviours. For instance the holds view will not display any items, when the detail page will display all of them (because we are not using the same code, we are in transition to merge it). This patch suggests to add a warning to the about page in case the query generated by Koha::Items->filter_by_visible_in_opac produces a warning
The only thing I can think of is to display a warning to the about page. Would that work for you, Andrew?
Created attachment 119534 [details] Message larger than table Seems reasonable! The real pain here is that it took a while to figure out that this system preference was the cause of the error, so a warning is definitely helpful. I've got a really picky display complaint, though. On Chrome, the warning message ends up a little longer than the table itself and doesn't look good. Can you make the table resize to fit the message?
Created attachment 119539 [details] [review] Bug 28125: Display a warning on the about page for OPACHiddenItems is needed If OPACHiddenItems is containing badly construct it will lead to inconsistent behaviours. For instance the holds view will not display any items, when the detail page will display all of them (because we are not using the same code, we are in transition to merge it). This patch suggests to add a warning to the about page in case the query generated by Koha::Items->filter_by_visible_in_opac produces a warning
(In reply to Andrew Fuerste-Henry from comment #3) > I've got a really picky display complaint, though. On Chrome, the warning > message ends up a little longer than the table itself and doesn't look good. > Can you make the table resize to fit the message? There was a td instead of a th, should be fixed now!
Created attachment 119540 [details] [review] Bug 28125: Display a warning on the about page for OPACHiddenItems is needed If OPACHiddenItems is containing badly construct it will lead to inconsistent behaviours. For instance the holds view will not display any items, when the detail page will display all of them (because we are not using the same code, we are in transition to merge it). This patch suggests to add a warning to the about page in case the query generated by Koha::Items->filter_by_visible_in_opac produces a warning Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Thank you!
Created attachment 119682 [details] [review] Bug 28125: Display a warning on the about page for OPACHiddenItems is needed If OPACHiddenItems is containing badly construct it will lead to inconsistent behaviours. For instance the holds view will not display any items, when the detail page will display all of them (because we are not using the same code, we are in transition to merge it). This patch suggests to add a warning to the about page in case the query generated by Koha::Items->filter_by_visible_in_opac produces a warning Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 119683 [details] [review] Bug 28125: (QA follow-up) Fix missing filter Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Patches have been squashed is master
Pushed to 20.11.x for 20.11.06