Bug 28394

Summary:	Improve style of patron category entry form
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	kyle, lucas
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	21.11.00
Circulation function:
Attachments:	Bug 28394: Improve style of patron category entry form Bug 28394: Improve style of patron category entry form Bug 28394: Improve style of patron category entry form

Description Owen Leonard 2021-05-19 16:09:25 UTC

There are some issues with alignment, padding, and other styles that I'd like to correct on admin/categories.tt

Comment 1 Owen Leonard 2021-05-19 17:46:13 UTC

Created attachment 121191 [details] [review]
Bug 28394: Improve style of patron category entry form

This patch makes some style and structure changes to the patron
cartegory entry form:

- Margin added to the enrollment period fieldset so that it aligns with
  the rest of the form.
- Informational text inside the form wrapped in <div class="hint"> like
  it is on other pages.
- Converted heading tag to legend tag in the messaging preferences
  fieldset.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Go to Administration -> Patron categories -> New category and confirm
that the style updates look good.

Comment 2 Lucas Gass (lukeg) 2021-05-19 21:39:19 UTC

Created attachment 121202 [details] [review]
Bug 28394: Improve style of patron category entry form

This patch makes some style and structure changes to the patron
cartegory entry form:

- Margin added to the enrollment period fieldset so that it aligns with
  the rest of the form.
- Informational text inside the form wrapped in <div class="hint"> like
  it is on other pages.
- Converted heading tag to legend tag in the messaging preferences
  fieldset.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Go to Administration -> Patron categories -> New category and confirm
that the style updates look good.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Comment 3 Lucas Gass (lukeg) 2021-05-19 21:40:17 UTC

Very nice improvements!
Looks good on all screen sizes (all screen sizes that I test at least)

Comment 4 Nick Clemens (kidclamp) 2021-07-23 14:45:08 UTC

Created attachment 123135 [details] [review]
Bug 28394: Improve style of patron category entry form

This patch makes some style and structure changes to the patron
cartegory entry form:

- Margin added to the enrollment period fieldset so that it aligns with
  the rest of the form.
- Informational text inside the form wrapped in <div class="hint"> like
  it is on other pages.
- Converted heading tag to legend tag in the messaging preferences
  fieldset.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Go to Administration -> Patron categories -> New category and confirm
that the style updates look good.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 5 Jonathan Druart 2021-07-26 10:47:49 UTC

Pushed to master for 21.11, thanks to everybody involved!

Comment 6 Kyle M Hall (khall) 2021-07-30 16:15:51 UTC

Enhancement not backported for 21.05