Summary: | Most-circulated items (cat_issues_top.pl) is failing with MySQL 8 | ||
---|---|---|---|
Product: | Koha | Reporter: | Humberto Chula <development> |
Component: | Reports | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to oldoldoldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | critical | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle, m.de.rooy, victor, wainuiwitikapark |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28523 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.02,20.11.08,20.05.14,19.11.20
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 23996 | ||
Attachments: |
Bug 28524: Escape 'rank' in cat_issues_top.pl
Bug 28524: Escape 'rank' in cat_issues_top.pl Bug 28524: Escape 'rank' in cat_issues_top.pl |
Description
Humberto Chula
2021-06-07 21:14:15 UTC
Created attachment 122036 [details] [review] Bug 28524: Escape 'rank' in cat_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Most-circulated items Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, loca' at line 1 With this patch applied you see the report result view Created attachment 122394 [details] [review] Bug 28524: Escape 'rank' in cat_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Most-circulated items Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, loca' at line 1 With this patch applied you see the report result view Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 122416 [details] [review] Bug 28524: Escape 'rank' in cat_issues_top.pl It's a MySQL 8 keyword Test plan: Turn off strict_sql_modes (there are other problems in this script) Hit Home Reports > Most-circulated items Submit the form Without this patch you got: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, loca' at line 1 With this patch applied you see the report result view Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.02 Hi, Fridolin impostor here: Backported: Pushed to 20.11.x branch for 20.11.08 Backported: Pushed to 20.05.x branch for 20.05.14 Backported to 19.11.x for 19.11.20 |