koha_1 | DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'rank, syntax, encoding,recordtype) VALUES koha_1 | ('lx2.loc.gov',210,'LCDB','','','LIBRA' at line 2 at /usr/share/perl5/DBIx/RunSQL.pm line 273. https://dev.mysql.com/doc/refman/8.0/en/keywords.html => RANK (R); added in 8.0.2 (reserved)
Created attachment 95193 [details] [review] Bug 23997: Escape z3950servers.rank as it's a new MySQL 8 kw This patch will fix installation of Koha on MySQL 8 DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'rank, syntax, encoding,recordtype) VALUES ('lx2.loc.gov',210,'LCDB','','','LIBRA' at line 2 at /usr/share/perl5/DBIx/RunSQL.pm line 273. https://dev.mysql.com/doc/refman/8.0/en/keywords.html => RANK (R); added in 8.0.2 (reserved)
Another good catch with a trivial fix.. Passing QA
Nice work! Pushed to master for 19.11.00
backported to 19.05.x for 19.05.07
Looks like Nick introduced a regression for this on bug 17515