Bug 28527

Summary: Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: Staff interfaceAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, koha-training, Laura.escamilla, lisette
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 28294, 28520    
Bug Blocks: 22160    
Attachments: Bug 28527: Restore cancellation of transfers from Koha::Hold
Bug 28527: Update detail to display cancelled in transit transfers
Bug 28527: Deal with cancelled in transfer transfers when enqueueing
Bug 28527: Add handling for cancelled in transit transfers at checkin

Description Martin Renvoize (ashimema) 2021-06-08 11:07:05 UTC
If a transfer is cancelled whilst it is in transit (datesent set, but datearrived not) then we should still return it as in transit.

Bug 27993 added a condition to the 'in_transit' boolean which should be reverted.
We should also update the get_transfer (and get_transfers) methods to catch such cases and return those still active transfers and deal with them appropriately at check-in. (i.e. invoke the reverse transfer or pick the next transfer from the queue and notify the librarian of what subsequent actions they should take).
Comment 1 Martin Renvoize (ashimema) 2021-06-08 11:59:52 UTC
Bug 28520 is very specific for the Reserve/Holds case, but does not account for transfers triggered by other means or cancelled by other means.
Comment 2 Martin Renvoize (ashimema) 2021-06-09 13:33:36 UTC
Created attachment 121739 [details] [review]
Bug 28527: Restore cancellation of transfers from Koha::Hold

This aptch restores the cancellation of the transfers in transit when a
hold is cancelled.
Comment 3 Martin Renvoize (ashimema) 2021-06-09 13:33:39 UTC
Created attachment 121740 [details] [review]
Bug 28527: Update detail to display cancelled in transit transfers
Comment 4 Martin Renvoize (ashimema) 2021-06-09 13:33:43 UTC
Created attachment 121741 [details] [review]
Bug 28527: Deal with cancelled in transfer transfers when enqueueing

Addeding to the queue should be allowed when the active transfer
(in_transit) has been cancelled.
Comment 5 Martin Renvoize (ashimema) 2021-06-09 13:33:46 UTC
Created attachment 121742 [details] [review]
Bug 28527: Add handling for cancelled in transit transfers at checkin
Comment 6 Koha Training Catalyst 2022-07-07 20:19:39 UTC
Can you please provide a test plan?
Comment 7 Laura Escamilla 2023-05-18 18:55:42 UTC
Blocking for now until a test plan is available for sign offs. Thanks!
Comment 8 Katrin Fischer 2023-05-18 19:09:02 UTC
Missing test plan = Failed QA
Comment 9 Lisette Scheer 2025-04-24 16:31:05 UTC
All the blockers are closed so I'm putting this back to failed QA for no test plan.