|
Description
Tomás Cohen Arazi (tcohen)
2021-06-17 19:16:29 UTC
Created attachment 122174 [details] [review] Bug 28588: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 122175 [details] [review] Bug 28588: Add Koha::Checkouts::ReturnClaim->resolve This patch introduces a high-level method for resolving claims. The behavior intends to replace the code in the API controller that is used for resolving a claim. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 122176 [details] [review] Bug 28588: (follow-up) Make the API use the new method This patch adapts the controller method for resolving a return claim so it uses the Koha::Checkouts::ReturnClaim method instead. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 122179 [details] [review] Bug 28588: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 122180 [details] [review] Bug 28588: Add Koha::Checkouts::ReturnClaim->resolve This patch introduces a high-level method for resolving claims. The behavior intends to replace the code in the API controller that is used for resolving a claim. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 122181 [details] [review] Bug 28588: (follow-up) Make the API use the new method This patch adapts the controller method for resolving a return claim so it uses the Koha::Checkouts::ReturnClaim method instead. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 122219 [details] [review] Bug 28588: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 122220 [details] [review] Bug 28588: Add Koha::Checkouts::ReturnClaim->resolve This patch introduces a high-level method for resolving claims. The behavior intends to replace the code in the API controller that is used for resolving a claim. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 122221 [details] [review] Bug 28588: (follow-up) Make the API use the new method This patch adapts the controller method for resolving a return claim so it uses the Koha::Checkouts::ReturnClaim method instead. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 21.11, thanks to everybody involved! Enhancement not pushed to 21.05.x |