Created attachment 120335 [details] [review] Bug 28271: Add the ability to set a new lost status when a claim is resolved When a claim is resolved the librarian should be able to edit the lost status of the item. It is also letting a way out when BlockReturnOfLostItems is set (the lost status is stuck on ClaimReturnedLostValue as we remove the option to edit itemlost on the item edit form).
This patch follows the discussion we had on IRC earlier today http://irc.koha-community.org/koha/2021-04-30#i_2349886
Created attachment 120336 [details] [review] Bug 28271: Adjust API spec
That's really nice and slick! Three bits of feedback: - if the lost value dropdown defaulted to the item's current status it would make it harder for folks to accidentally change it - it would also be helpful if the dropdown noted which lost status the item is currently at, something like "Claims Returned (current status)" - something like "Not lost" would be more clear than just a blank line
Created attachment 120406 [details] [review] Bug 28271: Preselect the current item lost value
(In reply to Andrew Fuerste-Henry from comment #4) > That's really nice and slick! Three bits of feedback: > - if the lost value dropdown defaulted to the item's current status it would > make it harder for folks to accidentally change it Done. > - it would also be helpful if the dropdown noted which lost status the item > is currently at, something like "Claims Returned (current status)" Can you retest and you detail a bit more? I am not sure I see where you want it displayed. > - something like "Not lost" would be more clear than just a blank line Done.
Andrew, are you happy with this patchset?
Created attachment 122047 [details] Proposed wording I've attached a screenshot of the resolution interface. The item in question is currently set to the lost status cr. When resolving the claim, I'd like to see it default to maintaining the existing value. Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box. Thanks!
Created attachment 122054 [details] [review] Bug 28271: Add (current status)
(In reply to Andrew Fuerste-Henry from comment #8) > When resolving the claim, I'd like to see it default to maintaining the existing value. This is how it is supposed to work already :) > Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box. I have added "(current status)", without the uppercase.
(In reply to Jonathan Druart from comment #10) > (In reply to Andrew Fuerste-Henry from comment #8) > > > When resolving the claim, I'd like to see it default to maintaining the existing value. > > This is how it is supposed to work already :) This is not what it was doing yesterday (see my screenshot, that book was at status "cr" but the resolution popup defaulted to "None"). But it is working correctly as I test this morning. > > Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box. > > I have added "(current status)", without the uppercase. Looks great, thanks! However, this morning I went a step further and actually clicked "Resolve." In both Chrome and Firefox, when I click Resolve I get a little spinning wheel on the button that looks like Koha's working on it, but it just stops there. The browser console says ":8081/api/v1/return_claims/1/resolve:1 Failed to load resource: the server responded with a status of 400 (Bad Request)"
It's a bug in master, opened bug 28586.
Created attachment 122093 [details] [review] Bug 28271: Add the ability to set a new lost status when a claim is resolved When a claim is resolved the librarian should be able to edit the lost status of the item. It is also letting a way out when BlockReturnOfLostItems is set (the lost status is stuck on ClaimReturnedLostValue as we remove the option to edit itemlost on the item edit form).
Created attachment 122094 [details] [review] Bug 28271: Adjust API spec Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 122095 [details] [review] Bug 28271: Preselect the current item lost value Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 122096 [details] [review] Bug 28271: Add (current status) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 122120 [details] [review] Bug 28271: Add the ability to set a new lost status when a claim is resolved When a claim is resolved the librarian should be able to edit the lost status of the item. It is also letting a way out when BlockReturnOfLostItems is set (the lost status is stuck on ClaimReturnedLostValue as we remove the option to edit itemlost on the item edit form). Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 122121 [details] [review] Bug 28271: Adjust API spec Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 122122 [details] [review] Bug 28271: Preselect the current item lost value Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 122123 [details] [review] Bug 28271: Add (current status) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
*** Bug 26316 has been marked as a duplicate of this bug. ***
1+1 = 2, this is PQA :-D
Pushed to master for 21.11, thanks to everybody involved!
Enhancement not backported to 20.05 Jonathan, if you think this should be backported as a bug fix, let us know!
(In reply to Kyle M Hall from comment #24) > Enhancement not backported to 20.05 > > Jonathan, if you think this should be backported as a bug fix, let us know! Ask Andrew, but I think it would be good to have it into 21.05.
Pushed to 21.05.x for 21.05.11
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.