Summary: | tabloop not used in cataloguing plugins | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, kyle, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This technical change removes the "tabloop" variable that is passed from the add item form logic to the cataloguing plugins, as it is never used.
|
|
Version(s) released in: |
21.11.00
|
Circulation function: | |
Bug Depends on: | 27526 | ||
Bug Blocks: | 28445 | ||
Attachments: |
Bug 28769: Remove tabloop from cataloguing plugins
Bug 28769: Remove tabloop from cataloguing plugins Bug 28769: Remove tabloop from cataloguing plugins Bug 28769: Remove tabloop from cataloguing plugins Bug 28769: (QA follow-up) Fix another occurrence |
Description
Jonathan Druart
2021-07-27 14:33:11 UTC
Created attachment 123212 [details] [review] Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working. This is a trivial change, *but* it needs to be advertised because it might break custom cataloguing plugins. Created attachment 125748 [details] [review] Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 126085 [details] [review] Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Tomás Cohen Arazi from comment #2) > This is a trivial change, *but* it needs to be advertised because it might > break custom cataloguing plugins. Hmm. So trivial for skipping QA ? Do you think it needs an additional pair of eyes on this patch, Marcel? (In reply to Jonathan Druart from comment #6) > Do you think it needs an additional pair of eyes on this patch, Marcel? Well, at least might need. I will do it this week. Note that comment2 is no recommendation for using the fast lane :) QAing I wonder who wrote this in 2014: Note that some of these parameters are not used in most (if not all) plugins and may be obsoleted in the future (kept for now to provide backward compatibility). Somehow I mixed up tabloop and tagslib. Tabloop is probably the most useless one to pass. But tagslib might be a good candidate too now, especially since we cache these structures now. Created attachment 126304 [details] [review] Bug 28769: Remove tabloop from cataloguing plugins There is a "tabloop" variable that is passed from the add item form logic to the cataloguing plugins. But there is confusion, sometimes it's an iterator ($i) and sometimes (batchMod.pl) an array. Actually this tabloop variable is never used from cataloguing plugins, we should remove it. Test plan: Read the code and confirm the above. You can also test a couple of plugins and confirm that they are still working. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 126305 [details] [review] Bug 28769: (QA follow-up) Fix another occurrence Framework plugin unimarc_leader_authorities.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 21.11, thanks to everybody involved! |