Summary: | Warns from GetItemsInfo when biblio marked as serial | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, tomascohen, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.03,20.11.10
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 25790 | ||
Attachments: |
Bug 28776: Warns from GetItemsInfo when biblio marked as serial
Bug 28776: Warns from GetItemsInfo when biblio marked as serial Bug 28776: Warns from GetItemsInfo when biblio marked as serial |
Description
Nick Clemens (kidclamp)
2021-07-28 13:32:21 UTC
Created attachment 123251 [details] [review] Bug 28776: Warns from GetItemsInfo when biblio marked as serial GetItemsInfo sorts the items using serial fields if the biblio is defined as a serial The fields may not be defined. We can add a fallback to blank in this case To test: 1 - Mark a record with items as serial in the marc (942$s) 2 - At least one of the items should have no enumchron defined 3 - Load the detail page 4 - Warns in logs: [WARN] Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/C4/Items.pm line 811. 5 - Apply patch and restart all 6 - Reload the details page 7 - No more warns Created attachment 123865 [details] [review] Bug 28776: Warns from GetItemsInfo when biblio marked as serial GetItemsInfo sorts the items using serial fields if the biblio is defined as a serial The fields may not be defined. We can add a fallback to blank in this case To test: 1 - Mark a record with items as serial in the marc (942$s) 2 - At least one of the items should have no enumchron defined 3 - Load the detail page 4 - Warns in logs: [WARN] Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/C4/Items.pm line 811. 5 - Apply patch and restart all 6 - Reload the details page 7 - No more warns Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25790 Created attachment 123873 [details] [review] Bug 28776: Warns from GetItemsInfo when biblio marked as serial GetItemsInfo sorts the items using serial fields if the biblio is defined as a serial The fields may not be defined. We can add a fallback to blank in this case To test: 1 - Mark a record with items as serial in the marc (942$s) 2 - At least one of the items should have no enumchron defined 3 - Load the detail page 4 - Warns in logs: [WARN] Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/C4/Items.pm line 811. 5 - Apply patch and restart all 6 - Reload the details page 7 - No more warns Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> https://bugs.koha-community.org/show_bug.cgi?id=25790 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.03 Pushed to 20.11.x for 20.11.10 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |