Bug 28858

Summary: Table Settings should control Checked out by field in Circulation history
Product: Koha Reporter: Sally <sally.healey>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, jonathan.druart
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Sally 2021-08-13 14:20:36 UTC
Koha Administration > Table Settings controls all whether fields are visible/can be toggled by users.  

'Checked out by' is solely controlled by a system preference (RecordStaffUserOnCheckout) - and is not an option in the Table Settings controls.

To replicate:

- Set system preference: RecordStaffUserOnCheckout to 'record'
- Check an item out to a patron
- Go to that patron's Circulation history - cgi-bin/koha/members/readingrec.pl
- Note that 'Checked out by' is visible and populated
- Go to Koha > Administration > Table Settings
- Choose Patrons
- Choose Page: checkouthistory
- Choose Table id:  checkouthistory-table
- Note that 'Checked out by' is not an option
Comment 1 Sally 2021-08-13 14:27:42 UTC
This also has the effect of targeting the wrong field via Table Settings.

To replicate:

- Set system preference: RecordStaffUserOnCheckout to 'record'
- Check an item out to a patron
- Go to that patron's Circulation history - cgi-bin/koha/members/readingrec.pl
- Note that 'Checked out by' is visible and populated
- Go to Koha > Administration > Table Settings
- Choose Patrons
- Choose Page: checkouthistory
- Choose Table id:  checkouthistory-table
- Check some fields to be 'Is hidden by default' i.e. 'checked_out_from' and 'date_due'
- Reload the patron's Circulation history
- Note that the columns 'Checked out from' and 'Checked out by' are hidden, but 'Date due' is not

This is because 'Checked out by' is sitting in the original 'Date due' position in the table.
Comment 2 Jonathan Druart 2021-10-25 09:00:58 UTC

*** This bug has been marked as a duplicate of bug 28859 ***