Koha Administration > Table Settings controls all whether fields are visible/can be toggled by users. 'Checked out by' is solely controlled by a system preference (RecordStaffUserOnCheckout) - and is not an option in the Table Settings controls. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Note that 'Checked out by' is not an option This also has the effect of targeting the wrong field via Table Settings. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Check some fields to be 'Is hidden by default' i.e. 'checked_out_from' and 'renewed' - Reload the item's Checkout history - Note that the columns 'Checked out from' and 'Checked out by' are hidden, but 'Renewed' is not This is because 'Checked out by' is sitting in the original 'Renewed' position in the table.
Caused by commit eb283d13fab70d8a32216a5bee8fb4a71e6d875e Bug 23916: Record and display item issuer Andrew, can you fix this please?
*** Bug 28916 has been marked as a duplicate of this bug. ***
Created attachment 124986 [details] [review] Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen
Created attachment 124990 [details] [review] Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I am sorry, but the table configuration is broken with this patch applied and the preference set to "don't record".
Uncaught TypeError: b.settings()[0].aoColumns[d] is undefined
Created attachment 126146 [details] [review] Bug 28859: Correctly handle 'Checked out by' visibility We must have the column in the table and let DT deal with the visibility. This patch hides the "Checked out by" column by default if RecordStaffUserOnCheckout is off, but the DT column settings is aware of its existence and the end user can still display the column. IMO that's the most optimal situation considering both maintenance and ergonomic.
*** Bug 28858 has been marked as a duplicate of this bug. ***
Created attachment 127030 [details] [review] Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 127031 [details] [review] Bug 28859: Correctly handle 'Checked out by' visibility We must have the column in the table and let DT deal with the visibility. This patch hides the "Checked out by" column by default if RecordStaffUserOnCheckout is off, but the DT column settings is aware of its existence and the end user can still display the column. IMO that's the most optimal situation considering both maintenance and ergonomic. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I tested the whole bug series together (and separately for the individual QA's). This all works as expected now, thanks for working through it Jonathan. Passing QA
Pushed to master for 21.11, thanks to everybody involved!