Summary: | Wrong wording in authentication forms | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Authentication | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, dpavlin, e.betemps, jonathan.druart, joonas.kylmala, kyle, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00,21.05.05,20.11.11
|
Circulation function: | |
Attachments: |
Bug 28914: Uniform wording in authentication forms
Bug 28914: Uniform wording in authentication forms Bug 28914: Uniform wording in authentication forms Bug 28914: Fix wording in authentication forms Bug 28914: Fix wording in authentication forms Bug 28914: Fix wording in authentication forms |
Description
Fridolin Somers
2021-08-27 18:36:14 UTC
Created attachment 124196 [details] [review] Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" Created attachment 124216 [details] [review] Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 124218 [details] [review] Bug 28914: Uniform wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. Also in opac-user.pl ":" is missing. I propose we always use : Fields "Login:", "Password:" with a submit button "Log in". It will generate less translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see field "Login:" and button "Log in" 4) Same for webinstaller 5) Go to OPAC page /cgi-bin/koha/opac-user.pl 6) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I didn't dig deep, but I believe we already had agreed on that wording before and made changes. (In reply to Katrin Fischer from comment #4) > I didn't dig deep, but I believe we already had agreed on that wording > before and made changes. I don't find it either. Can we find it before we push this please? Does the change make sense even if the error says "Invalid username or password"? Actually, not resolved, "In Discussion": bug 7867 Can't read the bug right now, so not sure where/why we got stuck. I had in mind something more recent. Is it at least OK to change submit button "Login" to "Log in" ? (In reply to Fridolin Somers from comment #8) > Is it at least OK to change submit button "Login" to "Log in" ? It is for the submit button (log in where it as an action (verb), for example: Log in with your user id; login when you are referring to the details they use (noun or adjective), for example: Your login details are <username> and <password>, Enter your credentials in the login page. https://wiki.koha-community.org/wiki/Terminology#L Thanks for the info David :) I mean here : https://git.koha-community.org/Koha-community/Koha/src/commit/a5a3a330cfc7c7d6c35db13326745dabf8fe0df3/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt#L115 <p class="submit"><input id="submit-button" type="submit" value="Login" tabindex="4" /></p> We must replace with "Log in" right ? (In reply to Fridolin Somers from comment #10) > We must replace with "Log in" right ? Agreed! Created attachment 124872 [details] [review] Bug 28914: Fix wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. It is not correct according to terminology https://wiki.koha-community.org/wiki/Terminology#L Also in opac-user.pl ":" is missing, it generates new translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see button "Log in" 4) Go to OPAC page /cgi-bin/koha/opac-user.pl 5) Check you see fields "Login:" and "Password:" Ok now patch only fixes a submit button wording and adds ":" to inputs. Back to need signoff. Created attachment 124882 [details] [review] Bug 28914: Fix wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. It is not correct according to terminology https://wiki.koha-community.org/wiki/Terminology#L Also in opac-user.pl ":" is missing, it generates new translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see button "Log in" 4) Go to OPAC page /cgi-bin/koha/opac-user.pl 5) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 125023 [details] [review] Bug 28914: Fix wording in authentication forms In most authentication forms we see : Fields "Login:" and "Password:" with a submit button "Log in". In some places submit button contains "Login", which is confusing for translation. It is not correct according to terminology https://wiki.koha-community.org/wiki/Terminology#L Also in opac-user.pl ":" is missing, it generates new translation entries. Test plan: 1) Log out if you are logged in 2) Go to staff interface 3) Check you see button "Log in" 4) Go to OPAC page /cgi-bin/koha/opac-user.pl 5) Check you see fields "Login:" and "Password:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> In my opinion it would have been better to continue and finish the work started on bug 7867. Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.11 Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. |