QA comment: it's a tiny patch, but on OPAC, it's written "login" on opac-user.pl too, so it's inconsistent to fix it here. 

Marking failed QA.
(As it's string freeze for 3.10 today, this patch won't be in 3.10 even if a fix is provided soon)

I'm running through the Failed QA's trying to see if there is anything I can rescue. I don't understand why this failed QA though. Did the 'Click here' say 'login' before? 'Log in' as an action link or button seems fine. The label for the text box, however, should be consistent. This patch believes it should be 'Username'.

I am not sure about username, as it might look like only the username works in the field, but we also have the option to use the cardnumber for logging in. So I thought login was not bad there, but maybe someone else has a good idea?

I have attached a 3rd patch, which is a counter patch to the first two patches. That is, they change the Staff client to 'Login' and add an explanatory tooltip to the text boxes where you are expected to enter either a username or card number.

Based on Katrin Fischer's comment 6, I think my counter patch would acceptable. I do agree that login is more generic than username.

If the latter one is acceptable for QA purposes, please obsolete the first two (the one I signed off [2.17KB] and the one I added for bootstrap [2.08KB]).

I am wondering if some of the following occurrences of "Username" should be replaced too:

koha-tmpl/intranet-tmpl/prog/en/columns.def:<field name="borrowers.userid">Username</field>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:                  yes: Username and Password
koha-tmpl/intranet-tmpl/prog/en/modules/installer/auth.tt:<p><label>Username:<br />
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:                              <li id="ERROR_login_exist">Username/password already exists.</li>
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:                      Username: </label>
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:    <li><span class="label">Username: </span>[% userid %]</li>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt:                        <p>Username: [% borrower.userid %]</p>
koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.js:            $('#login_field').attr("placeholder", "Username or Email")
koha-tmpl/opac-tmpl/prog/en/modules/opac-registration-confirmation.tt:                    Username: [% borrower.userid %]
koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:       <label for="patronlogin">Username:</label>

Could you please have a look?

(In reply to Jonathan Druart from comment #10)
> I am wondering if some of the following occurrences of "Username" should be
> replaced too:
> 
> koha-tmpl/intranet-tmpl/prog/en/columns.def:<field
> name="borrowers.userid">Username</field>
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: 
> yes: Username and Password
> koha-tmpl/intranet-tmpl/prog/en/modules/installer/auth.tt:<p><label>Username:
> <br />
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:          
> <li id="ERROR_login_exist">Username/password already exists.</li>
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:          
> Username: </label>
> koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:    <li><span
> class="label">Username: </span>[% userid %]</li>
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt: 
> <p>Username: [% borrower.userid %]</p>
> koha-tmpl/opac-tmpl/prog/en/modules/opac-registration-confirmation.tt:      
> Username: [% borrower.userid %]

May not apply, is it really Username or is it a generic option between card number or username? I think in cases refering directly to userid, they should say username. The login allows a login by card number, so the prompt should be more generic.

Hmmm... the returned error message should be more generic too. Will patch that up.


> koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.js:           
> $('#login_field').attr("placeholder", "Username or Email")

This is like the title attribute. Though, should it be email or card number?


> koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:       <label
> for="patronlogin">Username:</label>

Self-checkout... Yes, this should be tweaked. Will patch that up.


> Could you please have a look?

I will change it back to Adrien after this, since I really don't have that much time now allocated to Koha support.

Adrien is no longer working on Koha - mayabe switch back to unassigned then.

I'll be watching to fix my patch, but I don't have time to add more. Hence the reset to default.

Looks good to me. Maybe a native speaker should pass QA on it?

Created attachment 28457 [details] [review]
[PASSED QA] Bug 7867: Staff and OPAC login areas lack consistency

This patch:
- Changes the Staff client's login area text from "Username:"
   into "Login:", since login is more generic than username.
- Adds a tool tip to the staff client's login area 'Login:'
   textbox: "Please enter your username or card number."
- Adds a tool tip to the main OPAC screen's login area 'Login:'
   textbox using the bootstrap theme:
   "Please enter your username or card number."
- Adds a tool tip to the main OPAC screen's login area 'Login:'
   textbox using the prog theme:
   "Please enter your username or card number."
- Adds a tool tip to the OPAC screen triggered by clicking the
   'Log in to your account' link in the top right using the
   bootstrap theme: "Please enter your username or card number."
- Adds a tool tip to the OPAC screen triggered by clicking the
   'Log in to your account' link in the top right using the
   bootstrap theme: "Please enter your username or card number."

NOTE: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt was
      modified similarly as well, though I don't think it can be
      triggered, since the modal login screen of bootstrap is
      triggered by the 'Log in to your account' link, and it no
      longer goes to page it did before. The page still exists
      by going there by pasting in the known URL.

TEST PLAN
---------
 1) Go to staff client.
 2) Log in and change the OPAC system preference opacthemes to
    'bootstrap'.
 3) Logout.
 4) Go to OPAC in a different tab.
    -- notice staff client's "Username:" differs from the
       OPAC's "Login" text.
 5) Click the 'Log in to your account' link in the top right.
    -- notice staff client's "Username:" differs from the
       OPAC's "Login" text.
 6) Go to http://YOUROPAC/cgi-bin/koha/opac-user.pl
    -- notice staff client's "Username:" differs from the
       OPAC's "Login" text.
 7) Log in to the staff client and change the OPAC system
     preference opacthemes to 'prog'.
 8) Logout
 9) In the OPAC tab, reload the page.
    -- notice staff client's "Username:" differs from the
       OPAC's "Login" text.
10) Click the icon in the top left to return to the main Koha
    screen.
    -- notice staff client's "Username:" differs from the
       OPAC's "Login" text.
11) Apply the patch
12) Repeat steps 1-10 again.
    -- The textbox associated with the login should have a
       tooltip: "Please enter your username or card number."
13) Run the koha qa test tool.

Followed test plan (without qa test tool). Login screens display as expected.
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Created attachment 28458 [details] [review]
[PASSED QA] Bug 7867 - Further tweaks on error messages related to login

As per Jonathan Druart's comments, self-checkout and error
messages related to logging in were tweaked.

TEST PLAN
----------
1) Purposefully fail to log in properly with staff client.
   -- it should say username.
2) Purposefully fail to log in properly with opac.
   -- it should say username.
3) Re-run 2 with for both prog and bootstrap themes.
4) Purposefully fail to log in properly with self-checkout.
   -- you should be prompted username and error should say
      username as well.
6) apply patch.
7) Re-run the steps, but this time messages should be related
   to login and not username.
8) run koha-qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. No errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

I have some mild concerns about the use of "Login" which seems to me to be very very uncommon parlance as far as web standardization goes. Every website I've checked either uses email address ( which we don't ) or "Username" It seems like it may be better to use the phrase "Username or card number" which is much more accurate and explanatory, but also far more unwieldy. It seems that "Login" is attempting to be a replacement for this phrase specifically by *not* being the string "Username".

In summary, I find this acceptable, but I think that literally having "Username or card number" would be the best solution. However, "Login" is much more terse and I think that by and large it will not cause confusion for patrons.

I have a translation question: the word "login" is ambiguous in English.  It can be a verb (to log in), or a noun referring to a username or user ID.  Are there languages that use two distinct words for those concepts?  If so, that would be a reason for running with "Username or cardnumber" or the like.

The noun and the verb are certainly different words in German.

Well, at least n this case :)

(In reply to Kyle M Hall from comment #21)
> In summary, I find this acceptable, but I think that literally having
> "Username or card number" would be the best solution. However, "Login" is
> much more terse and I think that by and large it will not cause confusion
> for patrons.

This is why you will note I added the following:
    title="Please enter your username or card number."
into the code. A hover over should clarify what is expected.

(In reply to M. Tompsett from comment #25)
> (In reply to Kyle M Hall from comment #21)
> > In summary, I find this acceptable, but I think that literally having
> > "Username or card number" would be the best solution. However, "Login" is
> > much more terse and I think that by and large it will not cause confusion
> > for patrons.
> 
> This is why you will note I added the following:
>     title="Please enter your username or card number."
> into the code. A hover over should clarify what is expected.

Remember that translators will be seeing lists of words and phrases.  So if one sees the word "Login" in the translation interface... quick, tell me whether it's the noun or verb form!

Worse... it can be both in different places for an identical string.

I was thinking the other day about logging in.
Log in
Log on
Sign in
Sign on

We have lost the space which distinguishes the "Login" (noun) from "Log in" (action/verb). This loss of the space is more apparent when we talk about logging in (verb) using your login (noun).

What we have here is the mess of language. :(

What is the best way to solve this case?

(In reply to M. Tompsett from comment #28)
> What is the best way to solve this case?

I still think Kyle's suggestion: "Username or card number"

If only we supported the message context strings (msgctxt) ...

(In reply to paxed from comment #30)
> If only we supported the message context strings (msgctxt) ...

Just looked this up. Yes, yes this would be a better solution.

I started to fix this patch, then realised that tooltips don't display when hovering over the Login text in the OPAC, so the patch doesn't really work anymore. I am keen to standardise though, does anyone have any updated opinions on the solution for this?

(In reply to Mark Tompsett from comment #31)
> (In reply to paxed from comment #30)
> > If only we supported the message context strings (msgctxt) ...
> 
> Just looked this up. Yes, yes this would be a better solution.

We now support it.

What is the best solution to fix this problem?

(In reply to Galen Charlton from comment #29)
> (In reply to M. Tompsett from comment #28)
> > What is the best way to solve this case?
> 
> I still think Kyle's suggestion: "Username or card number"

Won't it be too long in some languages?

*** This bug has been marked as a duplicate of bug 33766 ***