Summary: | Add missing foreign key constraints to holds queue table | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall <kyle> |
Component: | Hold requests | Assignee: | Kyle M Hall <kyle> |
Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, joonas.kylmala |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Bug Depends on: | |||
Bug Blocks: | 5334 | ||
Attachments: |
Bug 28972: Add missing foreign key constraints to holds queue table
Bug 28972: Add missing foreign key constraints to holds queue table Bug 28972: Add missing foreign key constraints to holds queue table Bug 28972: Make DB rev idempotent Bug 28972: Fix failing tests |
Description
Kyle M Hall
2021-09-08 12:00:30 UTC
Created attachment 124651 [details] [review] Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers Created attachment 124662 [details] [review] Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers Signed-off-by: David Nind <david@davidnind.com> Created attachment 125025 [details] [review] Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Created attachment 125055 [details] [review] Bug 28972: Make DB rev idempotent Pushed to master for 21.11, thanks to everybody involved! Tests from t/db_dependent/HoldsQueue.t and t/db_dependent/Koha/Item.t are failing. Please fix ASAP. Created attachment 125065 [details] [review] Bug 28972: Fix failing tests |