The table tmp_holdsqueue is missing a couple key constraints that should be there.
Created attachment 124651 [details] [review] Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers
Created attachment 124662 [details] [review] Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers Signed-off-by: David Nind <david@davidnind.com>
Created attachment 125025 [details] [review] Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Created attachment 125055 [details] [review] Bug 28972: Make DB rev idempotent
Pushed to master for 21.11, thanks to everybody involved!
Tests from t/db_dependent/HoldsQueue.t and t/db_dependent/Koha/Item.t are failing. Please fix ASAP.
Created attachment 125065 [details] [review] Bug 28972: Fix failing tests