| Summary: | Use Flatpickr on various pages | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle, martin.renvoize, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 28937 | ||
| Bug Blocks: | 29229 | ||
| Attachments: |
Bug 28983: Use Flatpickr on various pages
Bug 28983: Use Flatpickr on various pages Bug 28983: Use Flatpickr on various pages |
||
|
Description
Owen Leonard
2021-09-09 14:25:34 UTC
Created attachment 124719 [details] [review] Bug 28983: Use Flatpickr on various pages This patch replaces the use of jQueryUI's datepicker on various unrelated pages. To test, apply the patch and test the following pages to confirm that datepickers work correctly. "Linked" date fields should prevent a "to" selection which preceeds the selected "from" date. - Tools -> Patron clubs -> New club: Linked "start date" and "end date" fields. - ILL requests: Two linked pairs of date fields in the sidebar, "Date placed between" and "Updated between." Each pair should work correctly and table filtering by date should work correctly. - Tools -> Label creator -> Manage -> Layout batches -> Edit a batch -> Add items. This should trigger a popup window with a linked pair of date fields, "Added on or after date," and "Added on or before date." - Point of sale -> Transaction history: "From" and "To" linked date field in the "Older transactions" section. - Acquisitions -> Suggestions -> Add a suggestion: "Created by," "Accepted on," and "Managed by" fields. - Tools -> Tags -> Filter tags by date. I started to make this bug dependent on Bug 28987 because you can't actually test whether the label search by date works. But if you believe your eyes that the dates appear correctly in the input fields I think you can sign off. Created attachment 124728 [details] [review] Bug 28983: Use Flatpickr on various pages This patch replaces the use of jQueryUI's datepicker on various unrelated pages. To test, apply the patch and test the following pages to confirm that datepickers work correctly. "Linked" date fields should prevent a "to" selection which preceeds the selected "from" date. - Tools -> Patron clubs -> New club: Linked "start date" and "end date" fields. - ILL requests: Two linked pairs of date fields in the sidebar, "Date placed between" and "Updated between." Each pair should work correctly and table filtering by date should work correctly. - Tools -> Label creator -> Manage -> Layout batches -> Edit a batch -> Add items. This should trigger a popup window with a linked pair of date fields, "Added on or after date," and "Added on or before date." - Point of sale -> Transaction history: "From" and "To" linked date field in the "Older transactions" section. - Acquisitions -> Suggestions -> Add a suggestion: "Created by," "Accepted on," and "Managed by" fields. - Tools -> Tags -> Filter tags by date. Signed-off-by: David Nind <david@davidnind.com> Created attachment 125501 [details] [review] Bug 28983: Use Flatpickr on various pages This patch replaces the use of jQueryUI's datepicker on various unrelated pages. To test, apply the patch and test the following pages to confirm that datepickers work correctly. "Linked" date fields should prevent a "to" selection which preceeds the selected "from" date. - Tools -> Patron clubs -> New club: Linked "start date" and "end date" fields. - ILL requests: Two linked pairs of date fields in the sidebar, "Date placed between" and "Updated between." Each pair should work correctly and table filtering by date should work correctly. - Tools -> Label creator -> Manage -> Layout batches -> Edit a batch -> Add items. This should trigger a popup window with a linked pair of date fields, "Added on or after date," and "Added on or before date." - Point of sale -> Transaction history: "From" and "To" linked date field in the "Older transactions" section. - Acquisitions -> Suggestions -> Add a suggestion: "Created by," "Accepted on," and "Managed by" fields. - Tools -> Tags -> Filter tags by date. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All works, PQA Pushed to master for 21.11, thanks to everybody involved! |