Summary: | Reindent calendar template | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 28963 | ||
Attachments: |
Bug 28988: Reindent calendar template
Bug 29899: (follow-up) Add markup comments Bug 28988: Reindent calendar template Bug 29899: (follow-up) Add markup comments Bug 28988: Reindent calendar template Bug 28988: (follow-up) Add markup comments |
Description
Owen Leonard
2021-09-09 18:27:33 UTC
Created attachment 124720 [details] [review] Bug 28988: Reindent calendar template This patch performs general template cleanup to the calendar template: Make indentation consistent and trim trailing whitespace. To test, apply the patch and go to Tools -> Calendar. The page should look correct and work correctly. If you view the diff while ignoring whitespace the only changes should be where line breaks were introduced. Created attachment 124721 [details] [review] Bug 29899: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 124817 [details] [review] Bug 28988: Reindent calendar template This patch performs general template cleanup to the calendar template: Make indentation consistent and trim trailing whitespace. To test, apply the patch and go to Tools -> Calendar. The page should look correct and work correctly. If you view the diff while ignoring whitespace the only changes should be where line breaks were introduced. Signed-off-by: David Nind <david@davidnind.com> Created attachment 124818 [details] [review] Bug 29899: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=28988 Signed-off-by: David Nind <david@davidnind.com> Created attachment 125318 [details] [review] Bug 28988: Reindent calendar template This patch performs general template cleanup to the calendar template: Make indentation consistent and trim trailing whitespace. To test, apply the patch and go to Tools -> Calendar. The page should look correct and work correctly. If you view the diff while ignoring whitespace the only changes should be where line breaks were introduced. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 125319 [details] [review] Bug 28988: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=28988 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed the bug number on the follow-up patch. Something spotted while testing: we have a really heavy grey border around the options for adding/editing a calendar entry that doesn't quite fit with the background. Unfortunately there are several accessibility patches in the queue currently that are modifying this template. (In reply to Jonathan Druart from comment #8) > Unfortunately there are several accessibility patches in the queue currently > that are modifying this template. I've tried to move Bug 27631 along (Accessibility: Staff Client - <h1> on each page is Logo but should be page description/title). I rebased and signed off on the existing patches and submitted a follow-up that addresses the concerns which led me to mark it Failed QA. Other patches in that series don't apply anymore. I believe that the heading issue on the accessilibity patch set would not be a difficult one to fix if we pushed this first, so I'd say let's move forward with this and flatpickr for now. Both accessibility and the date widget switch are things we want to push forward. Pushed to master for 21.11, thanks to everybody involved! |