Bug 28988 - Reindent calendar template
Summary: Reindent calendar template
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 28963
  Show dependency treegraph
 
Reported: 2021-09-09 18:27 UTC by Owen Leonard
Modified: 2021-09-12 16:24 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 28988: Reindent calendar template (52.61 KB, patch)
2021-09-09 18:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 29899: (follow-up) Add markup comments (5.14 KB, patch)
2021-09-09 18:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 28988: Reindent calendar template (52.65 KB, patch)
2021-09-12 16:24 UTC, David Nind
Details | Diff | Splinter Review
Bug 29899: (follow-up) Add markup comments (5.19 KB, patch)
2021-09-12 16:24 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2021-09-09 18:27:33 UTC
I would like to update the calendar template so that it has consistent indentation. It also needs to have some trailing spaces removed.
Comment 1 Owen Leonard 2021-09-09 18:45:00 UTC
Created attachment 124720 [details] [review]
Bug 28988: Reindent calendar template

This patch performs general template cleanup to the calendar template:
Make indentation consistent and trim trailing whitespace.

To test, apply the patch and go to Tools -> Calendar.

The page should look correct and work correctly. If you view the diff
while ignoring whitespace the only changes should be where line breaks
were introduced.
Comment 2 Owen Leonard 2021-09-09 18:45:04 UTC
Created attachment 124721 [details] [review]
Bug 29899: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 3 David Nind 2021-09-12 16:24:36 UTC
Created attachment 124817 [details] [review]
Bug 28988: Reindent calendar template

This patch performs general template cleanup to the calendar template:
Make indentation consistent and trim trailing whitespace.

To test, apply the patch and go to Tools -> Calendar.

The page should look correct and work correctly. If you view the diff
while ignoring whitespace the only changes should be where line breaks
were introduced.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2021-09-12 16:24:51 UTC
Created attachment 124818 [details] [review]
Bug 29899: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

https://bugs.koha-community.org/show_bug.cgi?id=28988

Signed-off-by: David Nind <david@davidnind.com>