|
Description
Martin Renvoize (ashimema)
2021-09-13 14:03:19 UTC
Created attachment 125598 [details] [review] Bug 29005: Enable welcome email from patron imports This patch was updated from work done by Evangelische Theologische Faculteit to allow the patron import to send welcome emails to users when enabled. Created attachment 126039 [details] [review] Bug 29005: Enable welcome email from patron imports This patch was updated from work done by Evangelische Theologische Faculteit to allow the patron import to send welcome emails to users when enabled. Test plan 1. Enable 'AutoEmailOpacUser' system preference 2. Add a new user via the csv patron imports (Include a password and an email address for which you have access) 3. Check that you received a welcome email for the user. 4. Overwrite the previous user with a new password using CSV imports 5. Check that you received a welcome email again for the user. Created attachment 126040 [details] [review] Bug 29005: Enable welcome email from patron imports This patch was updated from work done by Evangelische Theologische Faculteit to allow the patron import to send welcome emails to users when enabled. Test plan 1. Enable 'AutoEmailOpacUser' system preference 2. Add a new user via the csv patron imports (Include a password and an email address for which you have access) 3. Check that you received a welcome email for the user. 4. Overwrite the previous user with a new password using CSV imports 5. Check that you received a welcome email again for the user. Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Credit where credit's due.. I've amended the patch author to reflect that ETF originally authored the patch and I just rescued it with a rebase for modern Koha versions. Welcome to the submissions ETF :) I'd like to see this as an option in the system preference as to which new patrons get the email - batch created, individually created, both, or neither. There are libraries that will do batch imports that do not want to send an email to the new users from the batch import, but do still want to send emails to users that are created individually. For instance, a public library will want to send emails to users they register in person, but when they do a batch upload of students to permit them access to digital resources, they don't want to send welcome emails to the students. I'm going to rework with bug in the light of bug 17648 now. Created attachment 131246 [details] [review] Bug 29005: Add option to send welcome email from patron imports This patch adds the ability to send the ACCTDETAILS notice for new users added using the patron import tool. Test plan 1. Create a valid csv for patron import that includes some new users, ensuring you add a valid email address for which you have access. 2. Import the users using the patron import tool and select the new 'Send email to new patrons' checkbox. 3. Check that the notice appears in the new patrons notices 4. Check that you received a welcome email for the user. Created attachment 131247 [details] [review] Bug 29005: Add option to send welcome email from patron imports This patch adds the ability to send the ACCTDETAILS notice for new users added using the patron import tool. Test plan 1. Create a valid csv for patron import that includes some new users, ensuring you add a valid email address for which you have access. 2. Import the users using the patron import tool and select the new 'Send email to new patrons' checkbox. 3. Check that the notice appears in the new patrons notices 4. Check that you received a welcome email for the user. Created attachment 131248 [details] [review] Bug 29005: Add support for the command line script This patch adds welcome email for new users support to the command line patron import tool. Created attachment 131249 [details] [review] Bug 29005: Add option to send welcome email from patron imports This patch adds the ability to send the ACCTDETAILS notice for new users added using the patron import tool. Test plan 1. Create a valid csv for patron import that includes some new users, ensuring you add a valid email address for which you have access. 2. Import the users using the patron import tool and select the new 'Send email to new patrons' checkbox. 3. Check that the notice appears in the new patrons notices 4. Check that you received a welcome email for the user. Created attachment 131250 [details] [review] Bug 29005: Add support for the command line script This patch adds welcome email for new users support to the command line patron import tool. Created attachment 131251 [details] [review] Bug 29005: Unit tests Add a unit test for the additional functionality of sending welcome emails from Koha::Patrons::Import. Created attachment 131252 [details] [review] Bug 29005: Add option to send welcome email from patron imports This patch adds the ability to send the ACCTDETAILS notice for new users added using the patron import tool. Test plan 1. Create a valid csv for patron import that includes some new users, ensuring you add a valid email address for which you have access. 2. Import the users using the patron import tool and select the new 'Send email to new patrons' checkbox. 3. Check that the notice appears in the new patrons notices 4. Check that you received a welcome email for the user. Created attachment 131253 [details] [review] Bug 29005: Add support for the command line script This patch adds welcome email for new users support to the command line patron import tool. Created attachment 131254 [details] [review] Bug 29005: Unit tests Add a unit test for the additional functionality of sending welcome emails from Koha::Patrons::Import. Created attachment 132782 [details] [review] Bug 29005: Add option to send welcome email from patron imports This patch adds the ability to send the ACCTDETAILS notice for new users added using the patron import tool. Test plan 1. Create a valid csv for patron import that includes some new users, ensuring you add a valid email address for which you have access. 2. Import the users using the patron import tool and select the new 'Send email to new patrons' checkbox. 3. Check that the notice appears in the new patrons notices 4. Check that you received a welcome email for the user. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 132783 [details] [review] Bug 29005: Add support for the command line script This patch adds welcome email for new users support to the command line patron import tool. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 132784 [details] [review] Bug 29005: Unit tests Add a unit test for the additional functionality of sending welcome emails from Koha::Patrons::Import. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 132909 [details] [review] Bug 29005: Add support for the command line script This patch adds welcome email for new users support to the command line patron import tool. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132910 [details] [review] Bug 29005: Unit tests Add a unit test for the additional functionality of sending welcome emails from Koha::Patrons::Import. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.05, thanks to everybody involved [U+1F984] *** Bug 18940 has been marked as a duplicate of this bug. *** |