| Summary: | Use font awesome icons on request.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, david, fridolin.somers, gmcharlt, lucas, nengard, oleonard, shi-yao.wang |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement updates the arrows used on the holds page for a record to change the hold priority. Instead of using images for the arrows, Font Awesome icons are now used.
In addition, you can now override the icons using any Font Awesome icons in the IntranetUserCSS system preference. For an example, see https://gitlab.com/-/snippets/2319364
|
Version(s) released in: |
22.11.00
|
| Circulation function: | |||
| Attachments: |
Bug 29057: Use font awesome icons on request.pl
Bug 29057: Use font awesome icons on request.pl Bug 29057: [alternate] Use font awesome icons on request.pl before pic nick patch owen patch Bug 29057: (follow-up) Make arrow border hover state the correct color Screenshot of interface using angle icons Bug 29057: [alternate] Use font awesome icons on request.pl Bug 29057: [alternate] Use font awesome icons on request.pl Bug 29057: [alternate] Use font awesome icons on request.pl |
||
|
Description
Nick Clemens (kidclamp)
2021-09-20 10:22:44 UTC
Created attachment 125049 [details] [review] Bug 29057: Use font awesome icons on request.pl To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29057: Use font awesome icons on request.pl error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc). error: could not build fake ancestor Patch failed at 0001 Bug 29057: Use font awesome icons on request.pl Created attachment 125061 [details] [review] Bug 29057: Use font awesome icons on request.pl To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected Patch no longer applies 8-(.. Applying: Bug 29057: Use font awesome icons on request.pl Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29057: Use font awesome icons on request.pl Created attachment 129413 [details] [review] Bug 29057: [alternate] Use font awesome icons on request.pl This patch offers an alternate take on using Font Awesome icons on the holds page in place of images as links. To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected I like Owen's patch. The only thing I would say is that the use of the using the 'fa-rotate-90 fa-fast-foward' icon in the 'Toggle set to lowest priority' <th> column looks awkward. Is it nessesary to have it in the <th>? We should take screen shots to present the 2 solutions And check if we can remove files img/go-xxx.png Patch doesn't apply. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29057: Use font awesome icons on request.pl Created attachment 131650 [details]
before pic
Created attachment 131651 [details]
nick patch
Created attachment 131652 [details]
owen patch
Added pics of before and after with both patches Obsoleting mine in favor of Owen's I'm testing. Looks good but I see some issues : When hovering button "Move hold to top/bottom" we see that horizontal line color does not change. This is because it is not part of the icon, it is a CSS border. Looks dangerous to me. Why is icon for "Toggle lower priority" different from "Move hold to bottom" ? I propose we use "angle" FA icons : https://fontawesome.com/v4/icon/angle-down https://fontawesome.com/v4/icon/angle-double-down Single arrow for "Move hold up/down" and double arrow for "Move hold to top/bottom". Created attachment 131877 [details] [review] Bug 29057: (follow-up) Make arrow border hover state the correct color Created attachment 131878 [details] Screenshot of interface using angle icons (In reply to Fridolin Somers from comment #14) > Why is icon for "Toggle lower priority" different from "Move hold to bottom" > ? I think it should be different because it performs a different function. I think the current version with the arrow images is confusing because they're not different enough. The angle icons are not my top choice, but it is nice that there could be three variations on the same one. I think I like the first version from Owen the best so far, but we do have an issue with the fifth icon (and kinda always had). I think on another bug we had discussed using something like a 'pin' to indicate that it pins the hold to the bottom. Could we do some combination of 'move to bottom' with a red pin in it or so? https://fontawesome.com/v3/icon/pushpin I think we need something similar but yet different (which makes it quite hard). > I think it should be different because it performs a different function. Ah OK I was not aware of that :) Tooltip text is a good first help. But a good icon would be nice. Maybe use "angle" icons to move up/down/top/bottom : https://fontawesome.com/v4/icon/angle-down https://fontawesome.com/v4/icon/angle-double-down And a "angle double down" with underline has 5th icon (toggle lowest priority). Meaning go to bottom and stick there. It sounds like this is not yet ready for testing and awaiting a new patch? Adjusting bug status - feel free to change back if I'm wrong If anyone wants to leave their vote on which of the options screenshotted in the attachments looks best to them maybe this could move forward. I like the one called "owen patch" the best, but they all nice improvements. Created attachment 134896 [details] [review] Bug 29057: [alternate] Use font awesome icons on request.pl This patch offers an alternate take on using Font Awesome icons on the holds page in place of images as links. This revised patch updates the icon implementation so that it is easier to override the Font Awesome icon selection with CSS. Test by adding the contents of this file to the IntranetUserCSS preference: https://gitlab.com/-/snippets/2319364 To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected the possibilities are endless https://snipboard.io/UCbkzr.jpg Created attachment 134942 [details] [review] Bug 29057: [alternate] Use font awesome icons on request.pl This patch offers an alternate take on using Font Awesome icons on the holds page in place of images as links. This revised patch updates the icon implementation so that it is easier to override the Font Awesome icon selection with CSS. Test by adding the contents of this file to the IntranetUserCSS preference: https://gitlab.com/-/snippets/2319364 To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected Signed-off-by: David Nind <david@davidnind.com> (In reply to Owen Leonard from comment #23) > the possibilities are endless https://snipboard.io/UCbkzr.jpg Nice! I agree with David choice, lets go this that [U+1F44A] Created attachment 134966 [details] [review] Bug 29057: [alternate] Use font awesome icons on request.pl This patch offers an alternate take on using Font Awesome icons on the holds page in place of images as links. This revised patch updates the icon implementation so that it is easier to override the Font Awesome icon selection with CSS. Test by adding the contents of this file to the IntranetUserCSS preference: https://gitlab.com/-/snippets/2319364 To test: 1 - Place some holds on a record 2 - View the 'Holds' tab in the staff interface 3 - Note the new icons 4 - Note their hover test 5 - Confirm the buttons still work as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be bacckported to 22.05.x unless requested *** Bug 4230 has been marked as a duplicate of this bug. *** |
