Summary: | Add filtering methods to Koha::ArticleRequests | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, m.de.rooy, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28684 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
Add re-usable pre-filtered searches to the Article Requests system.
|
Version(s) released in: |
21.11.00
|
Circulation function: | |||
Bug Depends on: | 27947 | ||
Bug Blocks: | 29083 | ||
Attachments: |
Bug 29082: Add filtering methods to Koha::ArticleRequests
Bug 29082: Add filtering methods to Koha::ArticleRequests Bug 29082: Add filtering methods to Koha::ArticleRequests Bug 29082: Add filtering methods to Koha::ArticleRequests Bug 29082: Simplify tests |
Description
Tomás Cohen Arazi (tcohen)
2021-09-22 18:18:04 UTC
Created attachment 125159 [details] [review] Bug 29082: Add filtering methods to Koha::ArticleRequests This patch adds handy methods for filtering Koha::ArticleRequests resultsets. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> *** Bug 28684 has been marked as a duplicate of this bug. *** Please specify on top of which bug this should be placed. (In reply to Marcel de Rooy from comment #3) > Please specify on top of which bug this should be placed. No particular dependency, it is a standalone dev, self-contained. (In reply to Tomás Cohen Arazi from comment #4) > (In reply to Marcel de Rooy from comment #3) > > Please specify on top of which bug this should be placed. > > No particular dependency, it is a standalone dev, self-contained. Sure? I thought I saw a new status somewhere ;) (In reply to Marcel de Rooy from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > (In reply to Marcel de Rooy from comment #3) > > > Please specify on top of which bug this should be placed. > > > > No particular dependency, it is a standalone dev, self-contained. > > Sure? I thought I saw a new status somewhere ;) Right Created attachment 125239 [details] [review] Bug 29082: Add filtering methods to Koha::ArticleRequests This patch adds handy methods for filtering Koha::ArticleRequests resultsets. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected, it well covered by tests. Signing off Created attachment 125263 [details] [review] Bug 29082: Add filtering methods to Koha::ArticleRequests This patch adds handy methods for filtering Koha::ArticleRequests resultsets. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 125639 [details] [review] Bug 29082: Add filtering methods to Koha::ArticleRequests This patch adds handy methods for filtering Koha::ArticleRequests resultsets. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/ArticleRequests.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Rebased on top of bug 27945 changes. Created attachment 125691 [details] [review] Bug 29082: Simplify tests Pushed to master for 21.11, thanks to everybody involved! |