Summary: | Holds to pull list can crash with a SQL::Abstract puke | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Hold requests | Assignee: | Bugs List <koha-bugs> |
Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | ajohnson, andrewfh, david.roberts, david, dcook, dpk, gmcharlt, jonathan.druart, kyle, martin.renvoize, matt.blenkinsop, nick, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30155 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 3142 | ||
Bug Blocks: | |||
Attachments: |
Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed
Bug 29087: Add unit tests |
Description
Galen Charlton
2021-09-22 21:16:14 UTC
Created attachment 127859 [details] [review] Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed This seems to be the way to go, but I don't think it's ready for integration. We should have the logic moved to Koha::ItemTypes and add test coverage. Will try and come back to this later. Galen, thanks for reporting this bug! Are you seeing this in master or stable? Our library system is seeing this bug as well. Had a lot of staff reporting the error message to me today. We have some libraries seeing this now as well, the rule mentioned here doesn't seem to be the culprit, but the error is the same. Which version? Did you try the patch? I've tried patching a customer site with this and it works OK. Happy to sign off (even though the bug isn't requesting it yet....) Should we move this to NSO or SO even? We see this occasionally on customer sites too.. we've even got it backported in a couple of cases I think. (In reply to Katrin Fischer from comment #8) > Should we move this to NSO or SO even? No, see comment 2. Created attachment 164936 [details] [review] Bug 29087: Add unit tests prove t/db_dependent/Koha/Items.t We're seeing this again on customer sites. Looking at the patch attached I'm not sure the code belongs in ItemTypes as the error is coming from the default circulation rules at its root. I've had a go at some unit tests for the patch Joubu did earlier. Would be good to get this resolved and pushed Not sure from the comments if this is ready for sign off, or if more discussion is required. |