Opening the holds to pull list page can crash with the following logged error: SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before v1.75 used to generate incorrect SQL when the -NOT IN operator was given an undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of SQL::Abstract will emit the logically correct SQL instead of raising this exception) at /usr/share/koha/lib/Koha/Objects.pm line 145 I've traced this to Koha::Holds->get_items_that_can_fill(). Among other things, this routine fetches a list of item types that cannot fill holds, i.e., cases where the 'holdallowed' rule value is 'not_allowed'. However, if your default rule is to not allow holds, the @hold_not_allowed_itypes list will end up including an entry whose value is undef. When passed to the item query, doing the -not_in filter on itype will result in the crash listed above. A quick fix might be to filter out undef from that list. That will fix the crash, but could lead to incorrect results if the default policy is to deny holds for all item types except for ones that are going to be specifically permitted.
Created attachment 127859 [details] [review] Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed
This seems to be the way to go, but I don't think it's ready for integration. We should have the logic moved to Koha::ItemTypes and add test coverage. Will try and come back to this later.
Galen, thanks for reporting this bug! Are you seeing this in master or stable?
Our library system is seeing this bug as well. Had a lot of staff reporting the error message to me today.
We have some libraries seeing this now as well, the rule mentioned here doesn't seem to be the culprit, but the error is the same.
Which version? Did you try the patch?
I've tried patching a customer site with this and it works OK. Happy to sign off (even though the bug isn't requesting it yet....)
Should we move this to NSO or SO even?
We see this occasionally on customer sites too.. we've even got it backported in a couple of cases I think.
(In reply to Katrin Fischer from comment #8) > Should we move this to NSO or SO even? No, see comment 2.
Created attachment 164936 [details] [review] Bug 29087: Add unit tests prove t/db_dependent/Koha/Items.t
We're seeing this again on customer sites. Looking at the patch attached I'm not sure the code belongs in ItemTypes as the error is coming from the default circulation rules at its root. I've had a go at some unit tests for the patch Joubu did earlier. Would be good to get this resolved and pushed
Not sure from the comments if this is ready for sign off, or if more discussion is required.
(In reply to David Nind from comment #13) > Not sure from the comments if this is ready for sign off, or if more > discussion is required. Yes, ready for signoff, we can move to a module later if needed.
The patch no longer applies: git bz apply 29087 Bug 29087 - Holds to pull list can crash with a SQL::Abstract puke 127859 - Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed 164936 - Bug 29087: Add unit tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed Using index info to reconstruct a base tree... M Koha/Items.pm M t/db_dependent/Koha/Holds.t M t/db_dependent/Koha/Items.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Items.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Items.t Auto-merging t/db_dependent/Koha/Holds.t Auto-merging Koha/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed
Created attachment 166354 [details] [review] Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed
Created attachment 166355 [details] [review] Bug 29087: Add unit tests prove t/db_dependent/Koha/Items.t
Created attachment 166359 [details] [review] Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed Signed-off-by: David Nind <david@davidnind.com>
Created attachment 166360 [details] [review] Bug 29087: Add unit tests prove t/db_dependent/Koha/Items.t Signed-off-by: David Nind <david@davidnind.com>
Thanks Matt! Testing notes (using KTD): 1. Tests pass before after the patches. 2. Hope that is sufficient for sign off, otherwise please change the status back to needs sign off.
There is something wrong with the first patch. My initial patch did not add that many tests.
Will be a rebase error on my part, having a look now
Created attachment 166527 [details] [review] Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed Signed-off-by: David Nind <david@davidnind.com>
Created attachment 166528 [details] [review] Bug 29087: Add unit tests prove t/db_dependent/Koha/Items.t Signed-off-by: David Nind <david@davidnind.com>
Rebased so that the first commit matches the original, except for changes in Items.t which are now covered in the second commit
WARN Koha/Items.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 136, now: 140) WARN t/db_dependent/Koha/Holds.t WARN tidiness The file is less tidy than before (bad/messy lines before: 162, now: 164) WARN t/db_dependent/Koha/Items.t WARN tidiness The file is less tidy than before (bad/messy lines before: 393, now: 397)
- my @hold_not_allowed_itypes = Koha::CirculationRules->search( + my $default_rule = Koha::CirculationRules->get_effective_rule( { rule_name => 'holdallowed', - branchcode => undef, - categorycode => undef, rule_value => 'not_allowed', } - )->get_column('itemtype'); + ); Shouldnt you look here for branch undef, category undef AND itemtype undef ? Than you know that there is a 'real' default rule that does not allow holds. If there is no such default rule but there is one itemtype with not_allowed, the if default_rule branch may calculate incorrectly? It would get all itemtypes and subtract the ones which have an allowed rule, but they may not be present since you only reject one itemtype..
Created attachment 168241 [details] [review] Bug 29087: (QA follow-up): Correct default rule search This patch includes a check that branchcode, categorycode and itemtype are null for the default rule
Created attachment 168242 [details] [review] Bug 29087: (QA follow-up): Fix QA tests
Holds test failed with me at first, but probably related to bad data. Fresh master passes. prove t/db_dependent/Koha/Items.t All tests successful. Files=1, Tests=20, 18 wallclock secs ( 0.08 usr 0.01 sys + 14.81 cusr 2.00 csys = 16.90 CPU) Result: PASS prove t/db_dependent/Koha/Holds.t All tests successful. Files=1, Tests=12, 16 wallclock secs ( 0.05 usr 0.01 sys + 12.97 cusr 2.24 csys = 15.27 CPU) Result: PASS Apart from some noise in Items.t: Use of uninitialized value in string eq at /usr/share/koha/Koha/Item.pm line 102. => $self->barcode(undef) if $self->barcode eq ''; Not coming from here.
Can't really follow my own comment27 anymore ;) There seems to be no need for explicit undef passing to effective_rule. Will squash and edit.
Created attachment 169179 [details] [review] Bug 29087: Prevent filter_by_for_hold to crash if default holdallowed is not_allowed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 169180 [details] [review] Bug 29087: Add unit tests prove t/db_dependent/Koha/Items.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 169181 [details] [review] Bug 29087: (QA follow-up): Fix QA tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Conform BZ comment31
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant
Backported to 24.05.x for upcoming 24.05.04
Pushed to 23.11.x for 23.11.09
Not backporting to 23.05.x unless requested
This does not work! The method get_effective_rule cannot be used to filter on rule_value! my $default_rule = Koha::CirculationRules->get_effective_rule( { rule_name => 'holdallowed', rule_value => 'not_allowed', } ); print Dumper($default_rule->unblessed); $VAR1 = { 'categorycode' => undef, 'branchcode' => undef, 'rule_value' => 'from_any_library', 'id' => 268, 'itemtype' => undef, 'rule_name' => 'holdallowed' };