Summary: | reserves.desk_id for desk of waiting hold only updates when printing new hold slip | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Hold requests | Assignee: | Nicolas Legrand <nicolas.legrand> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle, martin.renvoize, nicolas.legrand, severine.queune |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.05
|
|
Circulation function: | |||
Bug Depends on: | 24412 | ||
Bug Blocks: | |||
Attachments: |
Bug 29103: Change desk when checking in a waiting reserve
Bug 29103: Change desk when checking in a waiting reserve Bug 29103: Change desk when checking in a waiting reserve |
Description
Andrew Fuerste-Henry
2021-09-23 21:18:39 UTC
Thanks a lot Andrew! My colleagues just pointed me this one yesterday. I may try to fix it, but I'll have soon a new child so I'm not sure I'll have time to work on this one before November. I'll try next week. Created attachment 129546 [details] [review] Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. Created attachment 129648 [details] [review] Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I don't really understand the change. Isn't it weird to force the submission when the button has a data-dismiss="modal"? Shouldn't we remove this "dismiss" attribute instead? We had lot of regressions on this page, I am a bit reluctant to submit when we were supposed not to... Created attachment 132194 [details] [review] Bug 29103: Change desk when checking in a waiting reserve A check in should relocate a waiting hold under the current desk. But the current behaviour when confirming the hold is to dismiss the modal, the item is still attached to the preceding desk. This patch mimicks the print and confirm behaviour to trigger the desk change. Plan test: 1. Add some desks to you library (syspref UseCirculationDesks and Administration -> Patrons and circulation -> Circulation desks. 2. Set a desk in your session (Circulation -> Set library and desk) 3. Have some waiting hold attach to a desk (make a hold on a checked out item and return it). 4. Change your current desk. 5. Check in again the item, click on confirm. 6. Go to the item notice detail, it appears as waiting at your first desk. 7. Apply patch. 8. Check in again the item. 9. go to the item notice detail, it should appear at your current desk. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, simple fix, works and no regressions found. Passing QA Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.05 |