Summary: | item_type should be item_type_id on item response object | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Circulation function: | |||
Bug Depends on: | 16825 | ||
Bug Blocks: | 29108 | ||
Attachments: |
Bug 29107: Rename item_type => item_type_id
Bug 29107: Rename item_type => item_type_id |
Description
Tomás Cohen Arazi (tcohen)
2021-09-24 11:26:34 UTC
Created attachment 125236 [details] [review] Bug 29107: Rename item_type => item_type_id This simple change renames the attribute in the item object API representation. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/items.t => SUCCESS: Tests pass 2. Run: $ git grep 'api/v1/items' => SUCCESS: The items routes are not (yet) used in Koha 3. Run: $ cd koha-tmpl $ git grep --name-only '"embed"' => SUCCESS: Only two templates are using embed. 4. Check: - register.tt uses it to embed the manager, good - parcel.tt uses it to embed items. Alert. => SUCCESS: parcel.tt only uses a count on items. No item_type involved. 5. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=29105 Created attachment 125253 [details] [review] Bug 29107: Rename item_type => item_type_id This simple change renames the attribute in the item object API representation. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/items.t => SUCCESS: Tests pass 2. Run: $ git grep 'api/v1/items' => SUCCESS: The items routes are not (yet) used in Koha 3. Run: $ cd koha-tmpl $ git grep --name-only '"embed"' => SUCCESS: Only two templates are using embed. 4. Check: - register.tt uses it to embed the manager, good - parcel.tt uses it to embed items. Alert. => SUCCESS: parcel.tt only uses a count on items. No item_type involved. 5. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial string fix.. going straight for PQA Pushed to master for 21.11, thanks to everybody involved! |