Summary: | Module navigation sidebars in staff now show bullet points | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Joonas Kylmälä <joonas.kylmala> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | joonas.kylmala, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Circulation function: | |||
Bug Depends on: | 27873 | ||
Bug Blocks: | |||
Attachments: |
Bug 29112: Module navigation sidebars in staff now show bullet points
Bug 29112: Module navigation sidebars in staff now show bullet points Bug 29112: Module navigation sidebars in staff now show bullet points |
Description
Katrin Fischer
2021-09-26 10:59:05 UTC
In earlier versions instead of the standard bullet point a custom image with a small arrow was used. The image link appears now to be broken, but it's still in the code - so I guess this was not inentional after all. Created attachment 125746 [details] [review] Bug 29112: Module navigation sidebars in staff now show bullet points Bug 27873 removed an image file which was still being referenced in the staff interface CSS, intended to replace the default bullet point in sidebar menus like Administration and Tools pages have. This patch creates a new variable in the SCSS "mixins" file so that the SVG image file created by Bug 27873 can be reused, and corrects the CSS for the affected menus. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Tools -> Patron lists - The sidebar menu should be styled with little arrows instead of the default HTML bullets. - Check the same on an Administration page, e.g. Administration -> Libraries. - Check that there hasn't been a regression on the checkout and patron detail views: - Check out to a patron who has one or more messages on their account, e.g. overdues, return claims, holds waiting, notes, messages, etc. - The display of these list items should be the same: An arrow bullet point instead of the default. Created attachment 125751 [details] [review] Bug 29112: Module navigation sidebars in staff now show bullet points Bug 27873 removed an image file which was still being referenced in the staff interface CSS, intended to replace the default bullet point in sidebar menus like Administration and Tools pages have. This patch creates a new variable in the SCSS "mixins" file so that the SVG image file created by Bug 27873 can be reused, and corrects the CSS for the affected menus. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Tools -> Patron lists - The sidebar menu should be styled with little arrows instead of the default HTML bullets. - Check the same on an Administration page, e.g. Administration -> Libraries. - Check that there hasn't been a regression on the checkout and patron detail views: - Check out to a patron who has one or more messages on their account, e.g. overdues, return claims, holds waiting, notes, messages, etc. - The display of these list items should be the same: An arrow bullet point instead of the default. Signed-off-by: David Nind <david@davidnind.com> Created attachment 126013 [details] [review] Bug 29112: Module navigation sidebars in staff now show bullet points Bug 27873 removed an image file which was still being referenced in the staff interface CSS, intended to replace the default bullet point in sidebar menus like Administration and Tools pages have. This patch creates a new variable in the SCSS "mixins" file so that the SVG image file created by Bug 27873 can be reused, and corrects the CSS for the affected menus. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Tools -> Patron lists - The sidebar menu should be styled with little arrows instead of the default HTML bullets. - Check the same on an Administration page, e.g. Administration -> Libraries. - Check that there hasn't been a regression on the checkout and patron detail views: - Check out to a patron who has one or more messages on their account, e.g. overdues, return claims, holds waiting, notes, messages, etc. - The display of these list items should be the same: An arrow bullet point instead of the default. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Fixes the problem, passing QA but noting down that those global variables could be moved in the future to _vars.scss now that we have such a file. Not blocking this because of that because there was pre-existing global variables already in the _mixins.scss file. Also, please describe in the commit what the change does and not what problem it solves, at least not in the title. Makes easier to verify intended changes, otherwise I have to guess based on the problem. Pushed to master for 21.11, thanks to everybody involved! |